You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
the logic in SplitUtils#getCombinedSplits clearly treats maxCombinedSplitSize as the min, and the actual split size may well exceed it.
The text was updated successfully, but these errors were encountered:
gerashegalov
changed the title
SplitUtils consistently misnames max for min split size
SplitUtils consistently misnames min as maxCombinedSplitSize
Oct 22, 2015
I guess it's poorly named, I think it's more like "target split size, but you may go over it if the last split to be combined is bigger" or something like that, right?
@dvryaboy@isnotinvain max and min can in theory be both targets. In most situations but a small single split, we keep piling up on a single split as long as we have not reached the min target. Would minTargetSize work to clarify that normally it's a lower bound?
the logic in SplitUtils#getCombinedSplits clearly treats maxCombinedSplitSize as the min, and the actual split size may well exceed it.
The text was updated successfully, but these errors were encountered: