Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support thrift TCompactProtocol in ThriftConverter #470

Open
gzm55 opened this issue Jul 28, 2016 · 0 comments
Open

Add support thrift TCompactProtocol in ThriftConverter #470

gzm55 opened this issue Jul 28, 2016 · 0 comments

Comments

@gzm55
Copy link

gzm55 commented Jul 28, 2016

Hi,

In many general cases, compact protocol bytes in lzo-block file can save 10%~15% size than binary protocol bytes, but the ThriftConverter can't choose other protocol factory than TBinaryProtocol.Factory when serialize() or deserialize().

Can we add two optional parameters,

  • first is to set a TProtocolFactory class name, used as output protocol when calling serialize();
  • second is to enable detecting the protocol via TProtocolUtil.guessProtocolFactory() when calling deserialize().

if neither is set, all behaviors of previous codes (MR/pig/hive, etc.) should be preserved.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant