Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Some focus add calls require subsequent focus sync #21

Open
arxanas opened this issue Sep 22, 2022 · 1 comment
Open

Some focus add calls require subsequent focus sync #21

arxanas opened this issue Sep 22, 2022 · 1 comment
Labels
bug Something isn't working

Comments

@arxanas
Copy link
Contributor

arxanas commented Sep 22, 2022

Describe the bug

Some focus add calls seem to drop dependencies from previous focus sync calls, necessitating another focus sync. I'm not sure why this happens.

To Reproduce

See FIXME comment in the CI job at https://github.com/twitter/focus/pull/17/files#diff-21364b2e6fae1f2875cee1ab3daefb0685403687eaf8bc32b5c6eacda351c9d3R47-R48

Expected behavior

The focus sync call should not be necessary.
@arxanas arxanas added the bug Something isn't working label Sep 22, 2022
@arxanas arxanas mentioned this issue Sep 22, 2022
Merged
@bierbaum
Copy link
Contributor

I think this may be fixed since we corrected the mutate method's backing up of the sparse profile. Let's try to see if we can repro it now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Milestone
No milestone
Development

No branches or pull requests
2 participants
@bierbaum @arxanas