Skip to content

Docker images shouldn't be used to ship config files around #861

@tyhal

Description

@tyhal

Its convenient to ship configuration files that tools need from inside container images but:

  • breaks host runs
  • splits tool configuration up - hard to reason about
  • need to include in crie config without needing to embed a bunch of random config formats

I think the cleanest solution would be extending the cli linter to have a list of config mappings

  • to: file path to write to (either in the container or onto the host)
  • from: file path to read from (tells crie to read the file from disk)
  • data: base64 embedded data (internally a byte array)

'from' would be useful for users to mount absolute paths into containers - the host cli executor can work out if from and to match it shouldn't do anything

crie would be able to mount when using from + to with containers
crie would probably need to have some tmp dir or config dir to write embedded data to then mount the file

then for tools that are in the default config either one of these paths

  • make a linter implementation that converts yml -> native config and then just uses the cli linter
  • just make a ymlUnmarshal for each tool that produces a cli linter object
  • make the data field instead be a generic yml to ini, toml, whatever convertor

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions