fs: close files that get dup'd over

tyler569 · tyler569 · commit aa22ad23333e · 2024-04-13T12:02:14.000-07:00
diff --git a/kernel/fs/file.c b/kernel/fs/file.c
@@ -104,7 +104,9 @@ int add_file(struct file *file) {
 
 int add_file_at(struct file *file, int at) {
 	file->magic = FILE_MAGIC;
-	dmgr_set(&running_process->fds, at, file);
+	struct file *old = dmgr_set(&running_process->fds, at, file);
+	if (old)
+		close_file(old);
 
 	return at;
 }

Original file line number	Diff line number	Diff line change
`@@ -104,7 +104,9 @@ int add_file(struct file *file) {`
`104`	`104`
`105`	`105`	`int add_file_at(struct file *file, int at) {`
`106`	`106`	`file->magic = FILE_MAGIC;`
`107`		`- dmgr_set(&running_process->fds, at, file);`
	`107`	`+ struct file *old = dmgr_set(&running_process->fds, at, file);`
	`108`	`+ if (old)`
	`109`	`+ close_file(old);`
`108`	`110`
`109`	`111`	`return at;`
`110`	`112`	`}`