Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Call for beta testing! #63

Closed
tyoma opened this issue Jan 6, 2021 · 10 comments
Closed

Call for beta testing! #63

tyoma opened this issue Jan 6, 2021 · 10 comments

Comments

@tyoma
Copy link
Owner

tyoma commented Jan 6, 2021

Guys,
You're on this list because you were/are at some point interested in MicroProfiler and left an issue or two here on github.
I have released a beta that has entirely rebuilt UI (particularly, the lists are now drawn by my code - except for parsing fonts, for which I use freetype2 library). Since there nobody else's helping me in developing MicroProfiler, I need your help in testing this release.
Should you decide to participate, the release is located here. Please, feel free open new issues here.
Have fun tackling it and Happy New Year!

Thanks a bunch!
Artem

@sebhtml, @pk1954, @SergeLalonde, @voidmonoid, @boimart1, @klukander, @srogatch, @janhec, @rold2007, @icnocop, @7wgs0gr04v, @denis-bu, @jpouderoux, @jcelerier, @Chaosmeister, @OlegRa

@jcelerier
Copy link

thanks!

@Lectem maybe interesting for you too ?

@Chaosmeister
Copy link

I'll take a look tomorrow. Thanks for posting!

@janhec
Copy link

janhec commented Jan 6, 2021 via email

@Lectem
Copy link

Lectem commented Jan 7, 2021

I'm sorry to say this @jcelerier and be a bit blunt, but I'm not really a fan of anything based on auto-instrumentation. It can be useful to know what functions are called most but other than that it's just not great for profiling (especially when it prevents any inlining) and prefer manual instrumentation coupled with sampling.

Anyway a few remarks for @tyoma for the UI since I tried it anyway:
(screenshot to illustrate)
image

  • Why does it automatically close when the program exits ? This means you can not profile command line programs easily
  • It's not immediately clear at first that the top panel is the caller list, and the bottom one is the list of callees
  • A tree view would be nice
  • The layout changed when I clicked to sort by inclusive time
    image
  • It would be better to have median/percentiles displayed rather than average, but I suppose it would require to store the values, so maybe not that good of an idea.
  • I couldnt resize the panels (the callees list is small)
  • The pie chart looks great, but a function name should be displayed when hovered

On other issues:

  • I'm getting negative time for some things: image (edit: see Negative execution times #57)
  • I paused my program, and while I was playing with the profiler window it closed itself after a few minutes / alt tabs? Are there logs ?

@tyoma
Copy link
Owner Author

tyoma commented Jan 7, 2021

Thank you @Lectem! This is very valuable!

  • The log(s) is/are located in %userprofile%\AppData\Local\.MicroProfiler, please, attach it to this issue. Spontaneous closes is not something expected and must be fixed.
  • What do you mean by 'layout changed'? What did it look like before?
  • Median (ant not only) values will be there, once I implement profile history (it is to display them I needed custom lists first).

As a sidenote: I get what you're saying about inlining - it may reduces the amount of functions inlined, but not prevent it. You can check it out yourself here - I ran profiling of the same agge rendition code with and without inlining (in Release, all other optimizations and flags are the same). You can look at the spreadsheet or at the profiles attached (you can open them from the Extensions/MicroProfiler/Open...) agge-rendition-with-or-without-inlining.zip

tyoma added a commit that referenced this issue Jan 9, 2021
- implements one of the requests in Issue #63 (#63 (comment)).
@Lectem
Copy link

Lectem commented Jan 9, 2021

What do you mean by 'layout changed'? What did it look like before?

See the space between the pie chart and the first column


Rest of the answer moved to #64

@tyoma
Copy link
Owner Author

tyoma commented Jan 11, 2021

moved to #64 (comment)

@Lectem
Copy link

Lectem commented Jan 11, 2021

Moved to #64 (comment)

@tyoma
Copy link
Owner Author

tyoma commented Jan 12, 2021

@Lectem Can you please move your comments on performance to this issue (#64), as they don't seem to be relevant?
Thanks!

@tyoma
Copy link
Owner Author

tyoma commented Jan 20, 2021

@Lectem I've published a version with some of the issues you mentioned earlier fixed. Here it is: https://github.com/tyoma/micro-profiler/releases/tag/v1.8.626.0
Meanwhile, I'm preparing my reply on #64.
Thank you!

@tyoma tyoma closed this as completed Oct 25, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants