feat(resolveConfig): stabilize "RESUME_DOWNLOAD" option

Though default it to "false"

Author: hasezoey

docs/api/config-options.md

@@ -281,15 +281,13 @@ Default: `3`
 
 Set this to control how many times the downloader will attempt to recover from transient errors (like network issues) before failing.
 
-### EXP_RESUME_DOWNLOAD
+### RESUME_DOWNLOAD
 
-|     Environment Variable      |     PackageJson     |
-| :---------------------------: | :-----------------: |
-| `MONGOMS_EXP_RESUME_DOWNLOAD` | `expResumeDownload` |
+|   Environment Variable    |     PackageJson     |
+| :-----------------------: | :-----------------: |
+| `MONGOMS_RESUME_DOWNLOAD` | `expResumeDownload` |
 
-Option `EXP_RESUME_DOWNLOAD` is used to enable / disable resuming a download of a binary instead of starting over on retries or interruptions.
-
-This is a experimental option, it maybe removed, renamed or have changed behavior in the future and any version.
+Option `RESUME_DOWNLOAD` is used to enable / disable resuming a download of a binary instead of starting over on retries or interruptions.
 
 Default: `false`
 

packages/mongodb-memory-server-core/src/util/MongoBinaryDownload.ts

@@ -478,7 +478,7 @@ export class MongoBinaryDownload {
     /** Offset to resume from; for now a non-0 value indicates to use file "append" mode */
     let offset = 0;
 
-    if (envToBool(resolveConfig(ResolveConfigVariables.EXP_RESUME_DOWNLOAD))) {
+    if (envToBool(resolveConfig(ResolveConfigVariables.RESUME_DOWNLOAD))) {
       const stat = await statPath(tempDownloadLocation);
 
       if (stat && stat.size != 0) {

packages/mongodb-memory-server-core/src/util/__tests__/MongoBinaryDownload.test.ts

@@ -432,7 +432,7 @@ describe('MongoBinaryDownload', () => {
     let key: string;
     let cert: string;
 
-    let exp_resume_before: any;
+    let resume_before: any;
 
     const totalBytes = 1024 * 10;
 
@@ -443,13 +443,13 @@ describe('MongoBinaryDownload', () => {
       key = await fspromises.readFile(path.resolve(certPath, './private-key.key'), 'utf-8');
       cert = await fspromises.readFile(path.resolve(certPath, './certificate.crt'), 'utf-8');
 
-      exp_resume_before = process.env[envName(ResolveConfigVariables.EXP_RESUME_DOWNLOAD)];
+      resume_before = process.env[envName(ResolveConfigVariables.RESUME_DOWNLOAD)];
     });
 
     beforeEach(async () => {
       tmpdir = await utils.createTmpDir('mongo-mem-test-download-');
 
-      delete process.env[envName(ResolveConfigVariables.EXP_RESUME_DOWNLOAD)];
+      delete process.env[envName(ResolveConfigVariables.RESUME_DOWNLOAD)];
     });
     afterEach(async () => {
       await utils.removeDir(tmpdir);
@@ -462,7 +462,7 @@ describe('MongoBinaryDownload', () => {
     });
 
     afterAll(() => {
-      process.env[envName(ResolveConfigVariables.EXP_RESUME_DOWNLOAD)] = exp_resume_before;
+      process.env[envName(ResolveConfigVariables.RESUME_DOWNLOAD)] = resume_before;
     });
 
     function createTestServer(
@@ -607,7 +607,7 @@ describe('MongoBinaryDownload', () => {
     });
 
     it('should download interrupt and resume', async () => {
-      process.env[envName(ResolveConfigVariables.EXP_RESUME_DOWNLOAD)] = 'true';
+      process.env[envName(ResolveConfigVariables.RESUME_DOWNLOAD)] = 'true';
 
       jest.spyOn(console, 'log').mockImplementation(() => void 0);
       createTestServer(totalBytes / 2);

packages/mongodb-memory-server-core/src/util/resolveConfig.ts

@@ -35,7 +35,7 @@ export enum ResolveConfigVariables {
   MAX_REDIRECTS = 'MAX_REDIRECTS',
   MAX_RETRIES = 'MAX_RETRIES', // Added for download retry configuration
   DISTRO = 'DISTRO',
-  EXP_RESUME_DOWNLOAD = 'EXP_RESUME_DOWNLOAD',
+  RESUME_DOWNLOAD = 'EXP_RESUME_DOWNLOAD',
 }
 
 /** The Prefix for Environmental values */
@@ -54,6 +54,7 @@ export const defaultValues = new Map<ResolveConfigVariables, string>([
   [ResolveConfigVariables.MD5_CHECK, 'true'],
   [ResolveConfigVariables.MAX_REDIRECTS, '2'],
   [ResolveConfigVariables.MAX_RETRIES, '3'], // Default maxRetries for downloads
+  [ResolveConfigVariables.RESUME_DOWNLOAD, 'false'],
 ]);
 
 /** Interface for storing information about the found package.json from `findPackageJson` */