Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add JSON schema #82

Open
krzema12 opened this issue Feb 2, 2023 · 3 comments
Open

Add JSON schema #82

krzema12 opened this issue Feb 2, 2023 · 3 comments
Labels
enhancement New feature or request

Comments

@krzema12
Copy link
Member

krzema12 commented Feb 2, 2023

To make it easier to build the YAML.
It can be also added here: https://github.com/SchemaStore/schemastore so that it's available by default in IntelliJ-based IDEs.

@krzema12 krzema12 added the enhancement New feature or request label Feb 2, 2023
@Vampire
Copy link
Collaborator

Vampire commented Aug 29, 2024

Where do you think it makes most sense to host the JSON schema, or what would you prefer?

Basically the two options are to host it in the schemastore repository and thus through their site,
or to host it here and just have an entry in the schemastore catalog that points at the URL where the schema is hosted.

Both have their pros and cons.

For example hosting it here it is closer to the definition and can be developed together with it,
but we probably then here need to build some testing infrastructure.

Hosting it in the schemastore repository, all the infrastructure is already there and you can just throw positive and negative YAML files in the according directories so that the schema is tested against those using Ajv, but it is like having the typing in the catalog instead of with the action itself, besides that the typing specification should most probably change way more seldom than an action changing inputs / outputs.

@Vampire
Copy link
Collaborator

Vampire commented Aug 29, 2024

Actually, I think I'm sufficiently happy with the schema I created, now I just need to know where I should contribute it to. :-D

@krzema12
Copy link
Member Author

I'd prefer to own it, and keep it in this repo for now (even though we need to add some testing infra), and later on we can mirror it in the schema store or add a reference like you mentioned.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants