Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Not clear that custom endpoints require that http.address is overrided #300

Open
tommpy opened this issue Dec 13, 2016 · 2 comments
Open

Comments

@tommpy
Copy link

tommpy commented Dec 13, 2016

Trying to get my app working on conductr for the first time I ran in to an annoying-to-track-down problem because I had set:

BundleKeys.endpoints := Map(
"payments" -> Endpoint("http", services = Set(URI("http://:9000")))
)

But omitted:
javaOptions in Bundle ++= Seq("-Dhttp.address=$PAYMENTS_BIND_IP", "-Dhttp.port=$PAYMENTS_BIND_PORT")

I think this page http://conductr.lightbend.com/docs/1.1.x/BundleConfiguration could do with a big red warning if you use a custom endpoint or something. Even better would be if the wiring was done automagically.

@markusjura
Copy link
Contributor

Also, in http://conductr.lightbend.com/docs/1.1.x/CreatingBundles we say:

Your application or service must be told what interface and port it should bind to when it runs. The Lagom and Play bundle plugins do that automatically.

The above explanation only works if the endpoint name is web and not a custom one. So we should be more descriptive here as well.

@huntc
Copy link
Contributor

huntc commented Dec 16, 2016

Can we have a PR please? Besides which, you shouldn't need to declare these javaOptions for Play or Lagom services as the sbt-conductr plugin will do it for you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants