fix: allow subTypes.name to be a number in DiscriminatorDescriptor #1683
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NoNameProvided
approved these changes
May 4, 2024
NoNameProvided
changed the title
subTypes.name to be a number in DiscriminatorDescriptor
NoNameProvided
force-pushed
the
nesro/fix-737
branch
from
d2e5465
to
c38159c
Compare
NoNameProvided
changed the title
subTypes.name to be a number in DiscriminatorDescriptor
5 tasks
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes #737 as it is a small fix, but very useful and needed.
It allows subTypes.name to be a number as well - useful when discriminating with a version property for example.
Checklist
Update index.md)develop)npm run prettier:checkpassesnpm run lint:checkpassesI did not edit the documentation as it doesn't mention the string type so it being a number is fine.
Fixes
fixes #737