-
Notifications
You must be signed in to change notification settings - Fork 85
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Mouse input is eaten on manual filter list updates on the moment the entry updates its numbers #3555
Comments
You'll need to make a screen recording showing what you mean. If a list was recently updated, it can simply reload from cache and the clock icon can simply blink without you noticing the update icon. That's the closest I could reproduce by your description. |
That's not unexpected, filter lists are loaded in memory in undefined order, so what is considered a duplicate in one list can become a duplicate in another list when they are reloaded in memory. |
A screen recording is a bit tricky here but I would try it with a more detailed example why I think the mouse input is being dropped here. With the current filters when I click the clock icon for "uBlock filters - Badware risks" its numbers update to 12.011/12.018. If I update "uBlock filters - Ads" afterwards its numbers will change to 40.551/40.667 and "uBlock filters - Badware risks" stays at 12.011/12.018. If I repeat this over and over "uBlock filters - Ads" will change its numbers between 40.375/40.667 (after updating "uBlock filters - Badware risks") or 40.551/40.667 (after updating "uBlock filters - Ads"). However, when the mouse input bug occurs here - which happens when I click the clock icon for "uBlock filters - Ads" at the very exact moment its numbers switch from 40.375/40.667 to 40.551/40.667 due to the previous "uBlock filters - Badware risks" update neither will the clock symbol show its loading animation (which could be explained by caching, etc. as you mentioned) nor will the numbers update (and this lets me believe the mouse input got dropped here). Trying to click at the exact moment is slightly tricky and needs a few tries. Usually I achieve this within 1-2 minutes. |
Prerequisites
I tried to reproduce the issue when...
Description
In the filter list dashboard when a filter list is manually updated by clicking its clock icon it can cause other filter lists to update their numbers. If such a filter list entry is also being manually updated by clicking its clock symbol at the exact moment those numbers update the mouse input is ignored and no filter list update happens.
A specific URL where the issue occurs.
/dashboard.html#3p-filters.html
Steps to Reproduce
Expected behavior
The filter list updates.
Actual behavior
The filter list doesn't update.
uBO version
1.62.0
Browser name and version
Firefox 135.0.1
Operating System and version
Windows 10 22H2
The text was updated successfully, but these errors were encountered: