Updating a filter list group multiple times in a row breaks the update logic

[Sworddragon]

Prerequisites

• I verified that this is not a filter list issue. Report any issues with filter lists or broken website functionality in the uAssets issue tracker.
• This is NOT a YouTube, Facebook or Twitch report. These sites MUST be reported by clicking their respective links.
• This is not a support issue or a question. For support, questions, or help, visit /r/uBlockOrigin.
• I performed a cursory search of the issue tracker to avoid opening a duplicate issue.
• The issue is not present after disabling uBO in the browser.
• I checked the documentation to understand that the issue I am reporting is not normal behavior.

I tried to reproduce the issue when...

• uBO is the only extension.
• uBO uses default lists and settings.
• using a new, unmodified browser profile.

Description

When updating a filter list group in the dashboard multiple times in a row by clicking its clock icon some lists will stay outdated and the update process aborts.

A specific URL where the issue occurs.

/dashboard.html#3p-filters.html

Steps to Reproduce

1. Go to uBlock Origin's filter list dashboard at /dashboard.html#3p-filters.html .
2. Update "uBlock filters" multiple times in a row by clicking its clock icon until it permanently shows a yellow triangle (in 4 different tests I achieved this after 2, 4, 2, 2 tries each so it is not hard to reproduce).

Expected behavior

All filter lists in the group should be up to date.

Actual behavior

Some filter lists show a yellow triangle for being outdated and the update process stops.

uBO version

1.62.0

Browser name and version

Firefox 135.0.1

Operating System and version

Windows 10 22H2

[stephenhawk8054]

@morcap Don't hijack other threads. Use the chat icon in uBO dashboard and follow the instructions and prerequisites.

[u-RraaLL]

• I checked the documentation to understand that the issue I am reporting is not normal behavior.

When updating a filter list group in the dashboard multiple times in a row

Personally, I think this falls under "abnormal use" category, but okay.

Here are easy repro steps:

1. Click the "uBlock filters" group clock.
2. Wait for it to turn green and instantly click it again. Do it before the "Update now" button becomes inactive (while lists are compiling).

Probably the easiest "fix" would be to lock clicking the icon until the lists are recompiled.

[Sworddragon]

Personally, I think this falls under "abnormal use" category, but okay.

Fair point, but I also don't use it that way. I just found this bug around a year ago when testing something, remembered it 2 days ago and tested if it still existed. Since this was the case I thought it might be fine just reporting it.

I also noticed another side effect that might or might not come from this issue: After triggering this bug filter list updates manually triggered afterwards were in an infinite loading animation once for me which lasted even after closing the filter list dashboard and reopening it a bit later. But it might not be worth investigating here more as this issue might just vanish once the bug in this report is fixed.

[MasterKia]

filter list updates manually triggered afterwards were in an infinite loading animation once for me which lasted even after closing the filter list dashboard and reopening it a bit later

Do you mean this?

bug.mp4

I've been having this problem for a long time.
When I try to update any one of the lists, even though the update gets downloaded but it gets stuck in updating mode until I change the tabs.

[Sworddragon]

Do you mean this?

Yes, except as far as I remember the loading animation persisted even after closing the tab in Firefox and reopening it later and I had to restart Firefox to fix it. But if you see this issue outside of this report's bug here you might want to create a ticket for it then (as I found mine randomly and have no steps to reproduce).

I also found another minor visual bug on all the testing the last days. But I'm unsure if I should really create a ticket now...^^' . Maybe a bit later as otherwise it won't go out of my head.