Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Incorporate requests params Argument #14

Closed
reyg3 opened this issue Jul 3, 2022 · 1 comment
Closed

Incorporate requests params Argument #14

reyg3 opened this issue Jul 3, 2022 · 1 comment
Assignees
@reyg3
Labels
enhancement New feature or request

Comments

@reyg3
Copy link
Member

reyg3 commented Jul 3, 2022

Looks good! The one update I would make that would help with issues like the missing = is to use dictionaries of query params instead of building urls. The params argument of requests.get can be used for this and examples can be found here https://requests.readthedocs.io/en/latest/user/quickstart/#passing-parameters-in-urls

Originally posted by @lboeman in #12 (review)
@reyg3 reyg3 added the enhancement New feature or request label Jul 3, 2022
@reyg3 reyg3 self-assigned this Jul 4, 2022
@reyg3
Copy link
Member Author

reyg3 commented Jul 6, 2022

#15

@reyg3 reyg3 closed this as completed Jul 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@reyg3 reyg3

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@reyg3