Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a comment explaining reason for or #16

Open
snadi opened this issue Aug 29, 2018 · 2 comments
Open

Add a comment explaining reason for or #16

snadi opened this issue Aug 29, 2018 · 2 comments

Comments

@snadi
Copy link
Contributor

snadi commented Aug 29, 2018

Document reason for or (mentioning the weird scenario you ran to if you can look it up)

https://github.com/ualberta-smr/code-owhadi-msr19/blob/1724d8a2ff6b334c0775a8498359ce892249d320/merge_excavator/code_quality.py#L28

@mkareshk
Copy link
Collaborator

mkareshk commented Sep 9, 2018

@snadi I couldn't remember the reason that I used both criteria, but since both of them are consistent with each other, I think we can keep them; correct?

@snadi
Copy link
Contributor Author

snadi commented Sep 10, 2018

Yeah, they are consistent. It's just a bit weird that you need both. I don't know if there are special cases when the process get interrupted for example and thus there is no BUILD FAILURE in the l og, but there is also no BUILD SUCCESS. Would that then get incorrectly counted as success?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants