Prevent theses and items sitemap views from using the same cache key #3361

jefferya · jefferya · commit 372cd65f4b4a · 2024-03-04T14:36:53.000-07:00
* adds a distinct cache key to the partial used by both the theses and items sitemap view
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -9,6 +9,9 @@ New entries in this file should aim to provide a meaningful amount of informatio
 
 ## [Unreleased]
 
+### Fixes
+* Prevent theses and items sitemap views from using the same cache key [#3361](https://github.com/ualbertalib/jupiter/pull/3400)
+
 ## [2.8.0] - 2024-02-28
 
 ### Added
diff --git a/app/views/sitemap/_object.xml.builder b/app/views/sitemap/_object.xml.builder
@@ -1,5 +1,5 @@
 xml.instruct! :xml, version: '1.0'
-cache 'sitemap', expires_in: 24.hours do
+cache cache_key, expires_in: 24.hours do
   xml.urlset(xmlns: 'http://www.sitemaps.org/schemas/sitemap/0.9') do
     xml.url do
       xml.loc        root_url
diff --git a/app/views/sitemap/items.xml.builder b/app/views/sitemap/items.xml.builder
@@ -1 +1 @@
-xml << render(partial: 'object', locals: { objects: @items })
+xml << render(partial: 'object', locals: { objects: @items, cache_key: 'sitemap-items' })
diff --git a/app/views/sitemap/theses.xml.builder b/app/views/sitemap/theses.xml.builder
@@ -1 +1 @@
-xml << render(partial: 'object', locals: { objects: @theses })
+xml << render(partial: 'object', locals: { objects: @theses, cache_key: 'sitemap-theses' })

Original file line number	Diff line number	Diff line change
`@@ -1 +1 @@`
`1`		`-xml << render(partial: 'object', locals: { objects: @items })`
	`1`	`+xml << render(partial: 'object', locals: { objects: @items, cache_key: 'sitemap-items' })`