Future use of subresource filter based adblock #143
Closed
BugmanSpirit
started this conversation in
Ideas
Replies: 1 comment 1 reply
-
the eyeo adblockplus code takes much of the logic of the subresource filter and extends it.
would be absolutely unnecessary and redundant
first you have to check if there is an impact on performance, in my opinion, no or it is irrelevant. |
Beta Was this translation helpful? Give feedback.
1 reply
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
-
I think maybe there is a better alternative to deprecating the subresource filter based adblock.
According to my understanding the subresource filter engine does not support the full adblock syntax. I am under the impression that it basically supports network based filter and a little more (like
||example.com^
). But I have read about subresource filter that it processes the requests much earlier in the rendering process. It is designed to have a minimal impact on the browser and is much faster than other adblocks.So it is fast and efficient but does not support as many syntax features as ABP.
So maybe we could have a process internally which goes like this:
Whenever the filter lists gets updated there would be some code that scans the unified list of all selected filters and separate the filters which can be processed by the subresource engine. Create another list for the subresource engine and these filters would then be removed from the unified filter list that just got updated. After this the browser would run the ruleset converter and prepare list.dat for the subresource filter engine.
This way we could offload some of the filtering load to the subresource filter engine that would block those requests before they come to ABP engine.
I think this should make the overall adblock more efficient and faster.
Beta Was this translation helpful? Give feedback.
All reactions