-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Change Diff Syntax #1
Comments
Note The following contributors may be suitable for this task: 0x4007
rndquu
|
@sshivaditya2019 ensure that the issue similarity searching is repo scoped. You can see beta keeps closing it because I transferred from another repo (presumably 100% match according to its database.) It should be attempting to link back to the original issue though, and it doesn't appear to be doing that. Be sure to handle that. |
I'm almost certain that this should only really require an update to The logger is not tied to comments but the If the intention is to make it clear when using the logger that this method is going to produce a Should the logger actually post the comment or just return the formatted string for the plugin to post? |
My original implementation had a post parameter do that |
I saw @gentlementlegen explained things in another comment just recently so I won't again here but what is to happen with my pr which has re-attached the posting capability for at least Supabase, should it also handle GitHub comment posting? The PR awaits review right now happy to make any other changes. |
Moved to ubiquity-os/ubiquity-os-logger#50 |
As it turns out, GitHub flavored markdown includes these handy color indicators. We can use the same color keys but instead of diff syntax, we use this syntax.
This should be applied across all kernel and plugin messages.
It might even be handy to rename the methods in our logger if its still attached to posting comments. The inspiration behind the rename is so that the class of message is no longer subjective.
Status Codes
Based on HTTP status codes, we should color code the responses. The only problem is that some of the headers can be misleading, but it does look a lot more aesthetically pleasing than the diffs. The left border in particular I think is a great minimal representation of the status.
Note
1xx
Tip
2xx
Important
3xx
Warning
4xx
Caution
5xx
Source Code
About HTTP Status Code Classes
Original Context
Warning
Failed to run comment evaluation.
TypeError: Cannot read properties of undefined (reading 'wordValue')
Originally posted by @0x4007 in ubiquity/.github#115 (comment)
Similar 1
Footnotes
Slow Start to Evaluation 75% ↩
The text was updated successfully, but these errors were encountered: