Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Installer config file #4

Closed
Keyrxng opened this issue Nov 26, 2024 · 6 comments
Closed

Installer config file #4

Keyrxng opened this issue Nov 26, 2024 · 6 comments

Comments

@Keyrxng
Copy link

Keyrxng commented Nov 26, 2024

  1. The installer is fetching from all repos not just plugins (.github, this repo, etc) and we can ignore them by parsing a config file in here via a simple opt.in/.out like we have with plugins etc.
  2. It's needed for Predefined configs ubiquity-os/ubiquity-os-plugin-installer#22 for a clean and optimal solution for template storage.
  3. It will likely gather more uses for it as we iterate on the installer UI.
@Keyrxng
Copy link
Author

Keyrxng commented Nov 26, 2024

@gentlementlegen @rndquu @zugdev Do you think we should do something like this?

@gentlementlegen
Copy link
Member

I think it's a bit redundant. What are your trying to achieve exactly?

@zugdev
Copy link

zugdev commented Nov 27, 2024

I don't see a github option in plugin selection, what is the problem?

@rndquu
Copy link
Member

rndquu commented Nov 27, 2024

@Keyrxng I think we can simply:

  1. Fetch all repos from https://github.com/ubiquity-os-marketplace
  2. If manifest.json exists in the root folder then it's a plugin, display it in https://github.com/ubiquity-os/ubiquity-os-plugin-installer

@rndquu rndquu closed this as not planned Won't fix, can't repro, duplicate, stale Nov 27, 2024
@Keyrxng
Copy link
Author

Keyrxng commented Nov 27, 2024

@Keyrxng I think we can simply:

  1. Fetch all repos from https://github.com/ubiquity-os-marketplace
  2. If manifest.json exists in the root folder then it's a plugin, display it in https://github.com/ubiquity-os/ubiquity-os-plugin-installer

That may solve for the slight annoyance of failed network requests, ideal, as it's not pretty to look at the console and see double digits failed network requests

My main point, which I could have put forward in a clearer way is: We need a place to store template configurations. Right now I've hardcoded three for the minimal template - https://github.com/ubiquity-os/ubiquity-os-plugin-installer/pull/28/files#diff-94071e7d80606fcfa081aaae82076f9468b056f9b078cb33cc80f1c0560c3c74.

So the cleaner and most optimal solution for templates would be an installer config file/folder that the installer fetches from

E.g:

ignoreRepos: [xyz,abc]
templates: {
 minimal: `yml config for this template`
 med: `yml config for this template`
 ...rest: ....

OR
thisRepo/.github/installer/templates/minimal.yml
thisRepo/.github/installer/settings >> ignoreRepos etc...


Templates could be left hardcoded into the installer UI build but it's better if we give them a place to live outside of the codebase and we fetch them.

I can just use the installer repo instead of this one but it made sense to me to keep all the plugin config ymls together including the templates.

@Keyrxng
Copy link
Author

Keyrxng commented Nov 27, 2024

I don't see a github option in plugin selection, what is the problem?

Relevant PR: ubiquity-os/ubiquity-os-plugin-installer#28
Relevant Task: ubiquity-os/ubiquity-os-plugin-installer#22

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants