-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Installer config file #4
Comments
@gentlementlegen @rndquu @zugdev Do you think we should do something like this? |
I think it's a bit redundant. What are your trying to achieve exactly? |
I don't see a github option in plugin selection, what is the problem? |
@Keyrxng I think we can simply:
|
That may solve for the slight annoyance of failed network requests, ideal, as it's not pretty to look at the console and see double digits failed network requests My main point, which I could have put forward in a clearer way is: We need a place to store template configurations. Right now I've hardcoded three for the So the cleaner and most optimal solution for templates would be an installer config file/folder that the installer fetches from E.g: ignoreRepos: [xyz,abc]
templates: {
minimal: `yml config for this template`
med: `yml config for this template`
...rest: .... OR Templates could be left hardcoded into the installer UI build but it's better if we give them a place to live outside of the codebase and we fetch them. I can just use the installer repo instead of this one but it made sense to me to keep all the plugin config ymls together including the templates. |
Relevant PR: ubiquity-os/ubiquity-os-plugin-installer#28 |
.github
, this repo, etc) and we can ignore them by parsing a config file in here via a simpleopt.in/.out
like we have with plugins etc.The text was updated successfully, but these errors were encountered: