Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Contributor Privacy Settings #68

Closed
Keyrxng opened this issue Oct 27, 2024 · 2 comments
Closed

Contributor Privacy Settings #68

Keyrxng opened this issue Oct 27, 2024 · 2 comments

Comments

@Keyrxng
Copy link
Contributor

Keyrxng commented Oct 27, 2024

The GitHub API fails us when our contributor' have their privacy settings restricted which may affect more than just the search API in question.

Rather than create an error handler in all octokit catch blocks:

  • create a method that makes a request that would hit this error as seen in the original context
  • call it on entry and if it fails throw
  • post a description of the error and a link to where to change it update settings if it's a privacy settings error

If a contributor does not want to change their settings then we either:

A) Do not allow them to contribute
B) Apply the lowest default limits and assumptions in all scenarios

original context

@0x4007
Copy link
Member

0x4007 commented Oct 27, 2024

I think b makes sense as long as we clearly explain to them how to fix the problem

@gentlementlegen
Copy link
Member

I think this can be closed because we implemented a fallback for such scenario.

@gentlementlegen gentlementlegen closed this as not planned Won't fix, can't repro, duplicate, stale Jan 14, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants