Change database pull-request tracking by organization configuration #2

gentlementlegen · 2024-07-28T05:12:07Z

The watcher should use GitHub API to go through all opened pull-requests instead of relying on a database. The main advantage is that we could get rid of the database which sole purpose is to keep track of the pull-requests to watch.

          It keeps track of the pull request to check updates for. Eventually, we could replace that with a list of organizations inside the configuration, which would allow us to totally remove the need for a database.

Originally posted by @gentlementlegen in #1 (comment)

The text was updated successfully, but these errors were encountered:

ubiquibot · 2024-07-28T05:14:33Z

@gentlementlegen the deadline is at 2024-07-28T09:14:33.524Z

ubiquibot · 2024-08-20T10:28:11Z

+ Evaluating results. Please wait...

ubiquityos · 2024-08-20T10:28:22Z

[ 125.2 WXDAI ]

@gentlementlegen

Contributions Overview

View	Contribution	Count	Reward
Issue	Task	1	100
Issue	Specification	1	25.2
Review	Comment	30	0

Conversation Incentives

Comment	Formatting	Relevance	Reward
The watcher should use GitHub API to go through all opened pull-…	25.2 content: p: count: 84 score: 1 em: count: 6 score: 0 wordValue: 0.1 formattingMultiplier: 3	1	25.2
Resolves #2 <!-- - You must link the issue number e.g. "Res…	0 content: p: count: 3 score: 1 ul: count: 18 score: 0 li: count: 18 score: 1 wordValue: 0 formattingMultiplier: 0	0.1	-
Yes it is just a placeholder for tests. I'll check if I can tota…	0 content: p: count: 23 score: 1 wordValue: 0.2 formattingMultiplier: 0	1	-
That would be really cool. The main problem would be to link the…	0 content: p: count: 48 score: 1 wordValue: 0.2 formattingMultiplier: 0	1	-
There is a lot of ongoing discussions on how to merge configurat…	0 content: p: count: 33 score: 1 wordValue: 0.2 formattingMultiplier: 0	1	-
404 means that the pull request is not merged: https://docs.git…	0 content: p: count: 40 score: 1 wordValue: 0.2 formattingMultiplier: 0	1	-
It is used in the timeline for the event date.	0 content: p: count: 10 score: 1 wordValue: 0.2 formattingMultiplier: 0	1	-
Oh I thought it would be automatically paginated after adding th…	0 content: p: count: 15 score: 1 wordValue: 0.2 formattingMultiplier: 0	1	-
In the current flow, it would log that there is an error and the…	0 content: p: count: 88 score: 1 code: count: 3 score: 1 wordValue: 0.2 formattingMultiplier: 0	1	-
@whilefoo added throw and related test.	0 content: p: count: 6 score: 1 wordValue: 0.2 formattingMultiplier: 0	1	-
For each `pullRequests` item I just pick up the destruct…	0 content: p: count: 25 score: 1 code: count: 2 score: 1 wordValue: 0.2 formattingMultiplier: 0	1	-
This is supposedly only called by the events defined within the …	0 content: p: count: 58 score: 1 code: count: 1 score: 1 wordValue: 0.2 formattingMultiplier: 0	1	-
Yes I agree I will split that. Interesting that `sonar` …	0 content: p: count: 16 score: 1 code: count: 1 score: 1 wordValue: 0.2 formattingMultiplier: 0	1	-
The reasoning was to not have a task without any event be stale …	0 content: p: count: 18 score: 1 wordValue: 0.2 formattingMultiplier: 0	1	-
I do not catch here to let it bubble up to the main call so erro…	0 content: p: count: 36 score: 1 wordValue: 0.2 formattingMultiplier: 0	1	-
A repo name requires the organization to be set. This is to avoi…	0 content: p: count: 31 score: 1 wordValue: 0.2 formattingMultiplier: 0	1	-
It is like this for most of our plugins. `cat` displays …	0 content: p: count: 22 score: 1 code: count: 3 score: 1 wordValue: 0.2 formattingMultiplier: 0	1	-
![image](https://github.com/user-attachments/assets/f92c0a0d-936…	0 content: p: count: 4 score: 1 img: count: 1 score: 0 wordValue: 0.2 formattingMultiplier: 0	1	-
We can do like the user watch and have both maybe.	0 content: p: count: 11 score: 1 wordValue: 0.2 formattingMultiplier: 0	1	-
If the author is part of the organization, we use the smallest t…	0 content: p: count: 17 score: 1 wordValue: 0.2 formattingMultiplier: 0	1	-
These are used only for testing.	0 content: p: count: 6 score: 1 wordValue: 0.2 formattingMultiplier: 0	1	-
## Major changes To get rid of the database which sole purpose …	0 content: h2: count: 4 score: 1 p: count: 67 score: 1 pre: count: 12 score: 0 code: count: 15 score: 1 ul: count: 23 score: 0 li: count: 23 score: 1 a: count: 3 score: 1 wordValue: 0.2 formattingMultiplier: 0	1	-
I can limit to the same organization eventually, but that actual…	0 content: p: count: 92 score: 1 code: count: 9 score: 1 pre: count: 5 score: 0 wordValue: 0.2 formattingMultiplier: 0	1	-
Then it would only be safe to run it within the org it is instal…	0 content: p: count: 36 score: 1 wordValue: 0.2 formattingMultiplier: 0	1	-
Latest QA: https://github.com/Meniole/automated-merging/pull/9	0 content: p: count: 3 score: 1 wordValue: 0.2 formattingMultiplier: 0	1	-
@Keyrxng you can specify a version for the targeted plugin, you …	0 content: p: count: 25 score: 1 code: count: 1 score: 1 wordValue: 0.2 formattingMultiplier: 0	1	-
Is the workflow present on the default branch?	0 content: p: count: 8 score: 1 wordValue: 0.2 formattingMultiplier: 0	1	-
I need a computer to test myself but I checked the repo and it s…	0 content: h2: count: 72 score: 1 p: count: 21 score: 1 code: count: 1 score: 1 wordValue: 0.2 formattingMultiplier: 0	1	-
I think it is okay because the merge timeout is represented as a…	0 content: p: count: 55 score: 1 wordValue: 0.2 formattingMultiplier: 0	1	-
Makes sense, will do the necessary changes.	0 content: p: count: 7 score: 1 wordValue: 0.2 formattingMultiplier: 0	1	-
QA run: https://github.com/Meniole/automated-merging/pull/10#pul…	0 content: p: count: 3 score: 1 wordValue: 0.2 formattingMultiplier: 0	1	-

[ 79.6 WXDAI ]

@Keyrxng

Contributions Overview

View	Contribution	Count	Reward
Review	Comment	18	79.6

Conversation Incentives

Comment	Formatting	Relevance	Reward
typebox enforces that `approvalsRequired > 0` but &#…	9.2 content: p: count: 84 score: 1 code: count: 8 score: 1 wordValue: 0.1 formattingMultiplier: 1	1	9.2
could probably destructure from context (apologize for the bad a…	1.3 content: p: count: 13 score: 1 wordValue: 0.1 formattingMultiplier: 1	1	1.3
Just above this line, what about `OWNER` shouldn't they …	5.2 content: p: count: 34 score: 1 code: count: 18 score: 1 wordValue: 0.1 formattingMultiplier: 1	1	5.2
Should we check length here otherwise `orgPassed` might …	1.3 content: p: count: 12 score: 1 code: count: 1 score: 1 wordValue: 0.1 formattingMultiplier: 1	1	1.3
missing `rest` here and also don't we usually wrap all o…	3.7 content: p: count: 36 score: 1 code: count: 1 score: 1 wordValue: 0.1 formattingMultiplier: 1	1	3.7
Is it safe to cast this? Could be safer with for-in or typeguard…	1.4 content: p: count: 14 score: 1 wordValue: 0.1 formattingMultiplier: 1	1	1.4
It seems strange that we attempt to merge if the `lastActivi…	1.9 content: p: count: 18 score: 1 code: count: 1 score: 1 wordValue: 0.1 formattingMultiplier: 1	1	1.9
Could this be made more readable It's sort of hard to grasp imme…	3 content: p: count: 30 score: 1 wordValue: 0.1 formattingMultiplier: 1	1	3
Without any checks this runs on any push event such as new branc…	1.8 content: p: count: 18 score: 1 wordValue: 0.1 formattingMultiplier: 1	1	1.8
this seemed to be the issue yeah, I had assumed it was an error …	3.5 content: p: count: 35 score: 1 wordValue: 0.1 formattingMultiplier: 1	1	3.5
Since I assume we are not tracking across multiple orgs I think …	1.7 content: p: count: 17 score: 1 wordValue: 0.1 formattingMultiplier: 1	1	1.7
Sorry terrible aiming, I meant all of the nested ifs within this…	1.4 content: p: count: 14 score: 1 wordValue: 0.1 formattingMultiplier: 1	1	1.4
That answers that question basically. So we are sort of starting…	2.7 content: p: count: 27 score: 1 wordValue: 0.1 formattingMultiplier: 1	1	2.7
Folks what's the schema for running action plugins with the late…	3.4 content: p: count: 32 score: 1 code: count: 2 score: 1 wordValue: 0.1 formattingMultiplier: 1	1	3.4
I bumped my local kernel and tried to QA yesterday but had issue…	3.1 content: p: count: 31 score: 1 wordValue: 0.1 formattingMultiplier: 1	1	3.1
@gentlementlegen I'm unsure what I'm doing wrong here. I have a…	10 content: p: count: 50 score: 1 code: count: 50 score: 1 pre: count: 44 score: 0 wordValue: 0.1 formattingMultiplier: 1	1	10
present on both branches yes, I haven't worked with workflows in…	9.8 content: p: count: 96 score: 1 code: count: 2 score: 1 wordValue: 0.1 formattingMultiplier: 1	1	9.8
I had issues running the workflow for this repo for ages, I had …	15.2 content: h2: count: 26 score: 1 p: count: 82 score: 1 code: count: 44 score: 1 pre: count: 43 score: 0 hr: count: 1 score: 0 wordValue: 0.1 formattingMultiplier: 1	1	15.2

[ 48.7 WXDAI ]

@0x4007

Contributions Overview

View	Contribution	Count	Reward
Review	Comment	13	48.7

Conversation Incentives

Comment	Formatting	Relevance	Reward
We should use `issues_comment.created` as the clock beca…	2.3 content: p: count: 21 score: 1 code: count: 2 score: 1 wordValue: 0.1 formattingMultiplier: 1	1	2.3
Is that right	0.3 content: p: count: 3 score: 1 wordValue: 0.1 formattingMultiplier: 1	1	0.3
One dream I always had was to have ChatGPT automatically commit …	7.9 content: p: count: 79 score: 1 wordValue: 0.1 formattingMultiplier: 1	1	7.9
It doesn't make sense to return an empty string. Instead it shou…	1.9 content: p: count: 18 score: 1 code: count: 1 score: 1 wordValue: 0.1 formattingMultiplier: 1	1	1.9
Confused about the use of `cat` and `./`	1 content: p: count: 8 score: 1 code: count: 2 score: 1 wordValue: 0.1 formattingMultiplier: 1	1	1
Syntax highlighting is broken. Does this file work as expected?	1 content: p: count: 10 score: 1 wordValue: 0.1 formattingMultiplier: 1	1	1
Why push? Should use `issues_comment.created` as this is…	1.3 content: p: count: 12 score: 1 code: count: 1 score: 1 wordValue: 0.1 formattingMultiplier: 1	1	1.3
Confused about whats going on in this line.	0.8 content: p: count: 8 score: 1 wordValue: 0.1 formattingMultiplier: 1	1	0.8
Perhaps this should be `issues_comment.created`	0.6 content: p: count: 5 score: 1 code: count: 1 score: 1 wordValue: 0.1 formattingMultiplier: 1	1	0.6
If we migrate to @ubiquity-os organization then we might need to…	1.3 content: p: count: 13 score: 1 wordValue: 0.1 formattingMultiplier: 1	1	1.3
### Concerns On This Approach The only thing that makes sense t…	21.2 content: h3: count: 8 score: 1 p: count: 188 score: 1 pre: count: 10 score: 0 code: count: 16 score: 1 wordValue: 0.1 formattingMultiplier: 1	1	21.2
I presume that the authentication is inherited from the original…	8.2 content: p: count: 79 score: 1 code: count: 3 score: 1 wordValue: 0.1 formattingMultiplier: 1	1	8.2
Should be able to still select branch. @gentlementlegen rfc	0.9 content: p: count: 9 score: 1 wordValue: 0.1 formattingMultiplier: 1	1	0.9

[ 4.45 WXDAI ]

@whilefoo

Contributions Overview

View	Contribution	Count	Reward
Review	Comment	10	4.45

Conversation Incentives

Comment	Formatting	Relevance	Reward
this is not used anymore, or is it?	0.2 content: p: count: 8 score: 1 wordValue: 0.1 formattingMultiplier: 0.25	1	0.2
why do you mock 404 for merge, won't this mean the run will fail…	0.8 content: p: count: 32 score: 1 wordValue: 0.1 formattingMultiplier: 0.25	1	0.8
ideally this plugin should be at the org level config, right? bu…	0.575 content: p: count: 23 score: 1 wordValue: 0.1 formattingMultiplier: 0.25	1	0.575
btw this info is also in `Context`'s payload	0.225 content: p: count: 8 score: 1 code: count: 1 score: 1 wordValue: 0.1 formattingMultiplier: 0.25	1	0.225
you can use `octokit.rest.search.issuesAndPullRequests` …	0.225 content: p: count: 8 score: 1 code: count: 1 score: 1 wordValue: 0.1 formattingMultiplier: 0.25	1	0.225
sorry maybe I wasn't clear, you still need to use paginate, just…	0.575 content: p: count: 20 score: 1 code: count: 3 score: 1 wordValue: 0.1 formattingMultiplier: 0.25	1	0.575
wouldn't it be better to throw the error?	0.2 content: p: count: 8 score: 1 wordValue: 0.1 formattingMultiplier: 0.25	1	0.2
```suggestion const owner = payload.repository.ow…	0.525 content: pre: count: 6 score: 0 code: count: 7 score: 1 p: count: 14 score: 1 wordValue: 0.1 formattingMultiplier: 0.25	1	0.525
if `monitor` is empty do we default to checking all repo…	0.7 content: p: count: 26 score: 1 code: count: 2 score: 1 wordValue: 0.1 formattingMultiplier: 0.25	1	0.7
this plugin only works within an org so "org" is useless, and "o…	0.425 content: p: count: 17 score: 1 wordValue: 0.1 formattingMultiplier: 0.25	1	0.425

ubiquibot · 2024-08-20T10:28:52Z

[ 46 WXDAI ]

@0x4007

Contributions Overview

View	Contribution	Count	Reward
Review	Comment	3	46

Conversation Incentives

Comment	Formatting	Relevance	Reward
### Concerns On This Approach The only thing that makes sense...	31.9 h3: count: 2 score: "2" words: 8 code: count: 8 score: "8" words: 7	0.92	31.9
> I should always check the org it comes from I presume t...	13.2 code: count: 5 score: "5" words: 9	0.86	13.2
Should be able to still select branch. @gentlementlegen rfc...	0.9	0.79	0.9

[ 344.7 WXDAI ]

@gentlementlegen

Contributions Overview

View	Contribution	Count	Reward
Issue	Specification	1	17
Issue	Task	1	100
Review	Comment	10	151.8
Review	Comment	10	75.9

Conversation Incentives

Comment	Formatting	Relevance	Reward
The watcher should use GitHub API to go through all opened pull-...	17 code: count: 1 score: "1" words: 0	1	17
## Major changes To get rid of the database which sole purpose ...	42.4 h2: count: 2 score: "4" words: 4 a: count: 1 score: "2" words: 3 li: count: 3 score: "6" words: 36 code: count: 4 score: "8" words: 7	0.95	42.4
I can limit to the same organization eventually, but that actual...	30 code: count: 5 score: "10" words: 5	0.85	30
Then it would only be safe to run it within the org it is instal...	7.2	0.8	7.2
Latest QA: https://github.com/Meniole/automated-merging/pull/9...	2	0.74	2
@Keyrxng you can specify a version for the targeted plugin, you ...	8.2 code: count: 1 score: "2" words: 7	0.81	8.2
> @gentlementlegen I'm unsure what I'm doing wrong here. >...	11.6 code: count: 5 score: "10" words: 6	0.77	11.6
I need a computer to test myself but I checked the repo and it s...	25.4 code: count: 1 score: "2" words: 6 hr: count: 1 score: "2" words: 0	0.79	25.4
> typebox enforces that `approvalsRequired > 0` bu...	21.2 code: count: 5 score: "10" words: 9	0.77	21.2
> > "org/repo" or "org" are the only accepted patterns. Yo...	1.4	0.77	1.4
QA run: https://github.com/Meniole/automated-merging/pull/10#pul...	2.4	0.81	2.4
## Major changes To get rid of the database which sole purpose ...	21.2 h2: count: 2 score: "2" words: 4 a: count: 1 score: "1" words: 3 li: count: 3 score: "3" words: 36 code: count: 4 score: "4" words: 7	0.95	21.2
I can limit to the same organization eventually, but that actual...	15 code: count: 5 score: "5" words: 5	0.85	15
Then it would only be safe to run it within the org it is instal...	3.6	0.8	3.6
Latest QA: https://github.com/Meniole/automated-merging/pull/9...	1	0.74	1
@Keyrxng you can specify a version for the targeted plugin, you ...	4.1 code: count: 1 score: "1" words: 7	0.81	4.1
> @gentlementlegen I'm unsure what I'm doing wrong here. >...	5.8 code: count: 5 score: "5" words: 6	0.77	5.8
I need a computer to test myself but I checked the repo and it s...	12.7 code: count: 1 score: "1" words: 6 hr: count: 1 score: "1" words: 0	0.79	12.7
> typebox enforces that `approvalsRequired > 0` bu...	10.6 code: count: 5 score: "5" words: 9	0.77	10.6
> > "org/repo" or "org" are the only accepted patterns. Yo...	0.7	0.77	0.7
QA run: https://github.com/Meniole/automated-merging/pull/10#pul...	1.2	0.81	1.2

[ 61.9 WXDAI ]

@Keyrxng

Contributions Overview

View	Contribution	Count	Reward
Review	Comment	5	61.9

Conversation Incentives

Comment	Formatting	Relevance	Reward
Folks what's the schema for running action plugins with the late...	6.1 code: count: 2 score: "2" words: 10	0.82	6.1
> @Keyrxng you can specify a version for the targeted plugin,...	4.3 code: count: 1 score: "1" words: 7	0.81	4.3
@gentlementlegen I'm unsure what I'm doing wrong here. I have...	16.5 code: count: 5 score: "5" words: 6	0.75	16.5
present on both branches yes, I haven't worked with workflows in...	11.8 code: count: 2 score: "2" words: 3	0.75	11.8
I had issues running the workflow for this repo for ages, I had ...	23.2 code: count: 3 score: "3" words: 1 hr: count: 2 score: "2" words: 0	0.78	23.2

[ 1.8 WXDAI ]

@whilefoo

Contributions Overview

View	Contribution	Count	Reward
Review	Comment	1	1.8

Conversation Incentives

Comment	Formatting	Relevance	Reward
> "org/repo" or "org" are the only accepted patterns. You nee...	1.8	0.8	1.8

ubiquibot · 2024-08-20T10:33:59Z

! action has an uncaught error

ubiquibot · 2024-08-20T10:34:04Z

+ Evaluating results. Please wait...

ubiquityos · 2024-08-20T10:34:13Z

[ 225.2 WXDAI ]

@gentlementlegen

Contributions Overview

View	Contribution	Count	Reward
Issue	Task	1	200
Issue	Specification	1	25.2
Review	Comment	30	0

Conversation Incentives

Comment	Formatting	Relevance	Reward
The watcher should use GitHub API to go through all opened pull-…	25.2 content: p: count: 84 score: 1 em: count: 6 score: 0 wordValue: 0.1 formattingMultiplier: 3	1	25.2
Resolves #2 <!-- - You must link the issue number e.g. "Res…	0 content: p: count: 3 score: 1 ul: count: 18 score: 0 li: count: 18 score: 1 wordValue: 0 formattingMultiplier: 0	0.1	-
Yes it is just a placeholder for tests. I'll check if I can tota…	0 content: p: count: 23 score: 1 wordValue: 0.2 formattingMultiplier: 0	1	-
That would be really cool. The main problem would be to link the…	0 content: p: count: 48 score: 1 wordValue: 0.2 formattingMultiplier: 0	1	-
There is a lot of ongoing discussions on how to merge configurat…	0 content: p: count: 33 score: 1 wordValue: 0.2 formattingMultiplier: 0	1	-
404 means that the pull request is not merged: https://docs.git…	0 content: p: count: 40 score: 1 wordValue: 0.2 formattingMultiplier: 0	1	-
It is used in the timeline for the event date.	0 content: p: count: 10 score: 1 wordValue: 0.2 formattingMultiplier: 0	1	-
Oh I thought it would be automatically paginated after adding th…	0 content: p: count: 15 score: 1 wordValue: 0.2 formattingMultiplier: 0	1	-
In the current flow, it would log that there is an error and the…	0 content: p: count: 88 score: 1 code: count: 3 score: 1 wordValue: 0.2 formattingMultiplier: 0	1	-
@whilefoo added throw and related test.	0 content: p: count: 6 score: 1 wordValue: 0.2 formattingMultiplier: 0	1	-
For each `pullRequests` item I just pick up the destruct…	0 content: p: count: 25 score: 1 code: count: 2 score: 1 wordValue: 0.2 formattingMultiplier: 0	1	-
This is supposedly only called by the events defined within the …	0 content: p: count: 58 score: 1 code: count: 1 score: 1 wordValue: 0.2 formattingMultiplier: 0	1	-
Yes I agree I will split that. Interesting that `sonar` …	0 content: p: count: 16 score: 1 code: count: 1 score: 1 wordValue: 0.2 formattingMultiplier: 0	1	-
The reasoning was to not have a task without any event be stale …	0 content: p: count: 18 score: 1 wordValue: 0.2 formattingMultiplier: 0	1	-
I do not catch here to let it bubble up to the main call so erro…	0 content: p: count: 36 score: 1 wordValue: 0.2 formattingMultiplier: 0	1	-
A repo name requires the organization to be set. This is to avoi…	0 content: p: count: 31 score: 1 wordValue: 0.2 formattingMultiplier: 0	1	-
It is like this for most of our plugins. `cat` displays …	0 content: p: count: 22 score: 1 code: count: 3 score: 1 wordValue: 0.2 formattingMultiplier: 0	1	-
![image](https://github.com/user-attachments/assets/f92c0a0d-936…	0 content: p: count: 4 score: 1 img: count: 1 score: 0 wordValue: 0.2 formattingMultiplier: 0	1	-
We can do like the user watch and have both maybe.	0 content: p: count: 11 score: 1 wordValue: 0.2 formattingMultiplier: 0	1	-
If the author is part of the organization, we use the smallest t…	0 content: p: count: 17 score: 1 wordValue: 0.2 formattingMultiplier: 0	1	-
These are used only for testing.	0 content: p: count: 6 score: 1 wordValue: 0.2 formattingMultiplier: 0	1	-
## Major changes To get rid of the database which sole purpose …	0 content: h2: count: 4 score: 1 p: count: 67 score: 1 pre: count: 12 score: 0 code: count: 15 score: 1 ul: count: 23 score: 0 li: count: 23 score: 1 a: count: 3 score: 1 wordValue: 0.2 formattingMultiplier: 0	1	-
I can limit to the same organization eventually, but that actual…	0 content: p: count: 92 score: 1 code: count: 9 score: 1 pre: count: 5 score: 0 wordValue: 0.2 formattingMultiplier: 0	1	-
Then it would only be safe to run it within the org it is instal…	0 content: p: count: 36 score: 1 wordValue: 0.2 formattingMultiplier: 0	1	-
Latest QA: https://github.com/Meniole/automated-merging/pull/9	0 content: p: count: 3 score: 1 wordValue: 0.2 formattingMultiplier: 0	1	-
@Keyrxng you can specify a version for the targeted plugin, you …	0 content: p: count: 25 score: 1 code: count: 1 score: 1 wordValue: 0.2 formattingMultiplier: 0	1	-
Is the workflow present on the default branch?	0 content: p: count: 8 score: 1 wordValue: 0.2 formattingMultiplier: 0	1	-
I need a computer to test myself but I checked the repo and it s…	0 content: h2: count: 72 score: 1 p: count: 21 score: 1 code: count: 1 score: 1 wordValue: 0.2 formattingMultiplier: 0	1	-
I think it is okay because the merge timeout is represented as a…	0 content: p: count: 55 score: 1 wordValue: 0.2 formattingMultiplier: 0	1	-
Makes sense, will do the necessary changes.	0 content: p: count: 7 score: 1 wordValue: 0.2 formattingMultiplier: 0	1	-
QA run: https://github.com/Meniole/automated-merging/pull/10#pul…	0 content: p: count: 3 score: 1 wordValue: 0.2 formattingMultiplier: 0	1	-

[ 79.6 WXDAI ]

@Keyrxng

Contributions Overview

View	Contribution	Count	Reward
Review	Comment	18	79.6

Conversation Incentives

Comment	Formatting	Relevance	Reward
typebox enforces that `approvalsRequired > 0` but &#…	9.2 content: p: count: 84 score: 1 code: count: 8 score: 1 wordValue: 0.1 formattingMultiplier: 1	1	9.2
could probably destructure from context (apologize for the bad a…	1.3 content: p: count: 13 score: 1 wordValue: 0.1 formattingMultiplier: 1	1	1.3
Just above this line, what about `OWNER` shouldn't they …	5.2 content: p: count: 34 score: 1 code: count: 18 score: 1 wordValue: 0.1 formattingMultiplier: 1	1	5.2
Should we check length here otherwise `orgPassed` might …	1.3 content: p: count: 12 score: 1 code: count: 1 score: 1 wordValue: 0.1 formattingMultiplier: 1	1	1.3
missing `rest` here and also don't we usually wrap all o…	3.7 content: p: count: 36 score: 1 code: count: 1 score: 1 wordValue: 0.1 formattingMultiplier: 1	1	3.7
Is it safe to cast this? Could be safer with for-in or typeguard…	1.4 content: p: count: 14 score: 1 wordValue: 0.1 formattingMultiplier: 1	1	1.4
It seems strange that we attempt to merge if the `lastActivi…	1.9 content: p: count: 18 score: 1 code: count: 1 score: 1 wordValue: 0.1 formattingMultiplier: 1	1	1.9
Could this be made more readable It's sort of hard to grasp imme…	3 content: p: count: 30 score: 1 wordValue: 0.1 formattingMultiplier: 1	1	3
Without any checks this runs on any push event such as new branc…	1.8 content: p: count: 18 score: 1 wordValue: 0.1 formattingMultiplier: 1	1	1.8
this seemed to be the issue yeah, I had assumed it was an error …	3.5 content: p: count: 35 score: 1 wordValue: 0.1 formattingMultiplier: 1	1	3.5
Since I assume we are not tracking across multiple orgs I think …	1.7 content: p: count: 17 score: 1 wordValue: 0.1 formattingMultiplier: 1	1	1.7
Sorry terrible aiming, I meant all of the nested ifs within this…	1.4 content: p: count: 14 score: 1 wordValue: 0.1 formattingMultiplier: 1	1	1.4
That answers that question basically. So we are sort of starting…	2.7 content: p: count: 27 score: 1 wordValue: 0.1 formattingMultiplier: 1	1	2.7
Folks what's the schema for running action plugins with the late…	3.4 content: p: count: 32 score: 1 code: count: 2 score: 1 wordValue: 0.1 formattingMultiplier: 1	1	3.4
I bumped my local kernel and tried to QA yesterday but had issue…	3.1 content: p: count: 31 score: 1 wordValue: 0.1 formattingMultiplier: 1	1	3.1
@gentlementlegen I'm unsure what I'm doing wrong here. I have a…	10 content: p: count: 50 score: 1 code: count: 50 score: 1 pre: count: 44 score: 0 wordValue: 0.1 formattingMultiplier: 1	1	10
present on both branches yes, I haven't worked with workflows in…	9.8 content: p: count: 96 score: 1 code: count: 2 score: 1 wordValue: 0.1 formattingMultiplier: 1	1	9.8
I had issues running the workflow for this repo for ages, I had …	15.2 content: h2: count: 26 score: 1 p: count: 82 score: 1 code: count: 44 score: 1 pre: count: 43 score: 0 hr: count: 1 score: 0 wordValue: 0.1 formattingMultiplier: 1	1	15.2

[ 48.7 WXDAI ]

@0x4007

Contributions Overview

View	Contribution	Count	Reward
Review	Comment	13	48.7

Conversation Incentives

Comment	Formatting	Relevance	Reward
We should use `issues_comment.created` as the clock beca…	2.3 content: p: count: 21 score: 1 code: count: 2 score: 1 wordValue: 0.1 formattingMultiplier: 1	1	2.3
Is that right	0.3 content: p: count: 3 score: 1 wordValue: 0.1 formattingMultiplier: 1	1	0.3
One dream I always had was to have ChatGPT automatically commit …	7.9 content: p: count: 79 score: 1 wordValue: 0.1 formattingMultiplier: 1	1	7.9
It doesn't make sense to return an empty string. Instead it shou…	1.9 content: p: count: 18 score: 1 code: count: 1 score: 1 wordValue: 0.1 formattingMultiplier: 1	1	1.9
Confused about the use of `cat` and `./`	1 content: p: count: 8 score: 1 code: count: 2 score: 1 wordValue: 0.1 formattingMultiplier: 1	1	1
Syntax highlighting is broken. Does this file work as expected?	1 content: p: count: 10 score: 1 wordValue: 0.1 formattingMultiplier: 1	1	1
Why push? Should use `issues_comment.created` as this is…	1.3 content: p: count: 12 score: 1 code: count: 1 score: 1 wordValue: 0.1 formattingMultiplier: 1	1	1.3
Confused about whats going on in this line.	0.8 content: p: count: 8 score: 1 wordValue: 0.1 formattingMultiplier: 1	1	0.8
Perhaps this should be `issues_comment.created`	0.6 content: p: count: 5 score: 1 code: count: 1 score: 1 wordValue: 0.1 formattingMultiplier: 1	1	0.6
If we migrate to @ubiquity-os organization then we might need to…	1.3 content: p: count: 13 score: 1 wordValue: 0.1 formattingMultiplier: 1	1	1.3
### Concerns On This Approach The only thing that makes sense t…	21.2 content: h3: count: 8 score: 1 p: count: 188 score: 1 pre: count: 10 score: 0 code: count: 16 score: 1 wordValue: 0.1 formattingMultiplier: 1	1	21.2
I presume that the authentication is inherited from the original…	8.2 content: p: count: 79 score: 1 code: count: 3 score: 1 wordValue: 0.1 formattingMultiplier: 1	1	8.2
Should be able to still select branch. @gentlementlegen rfc	0.9 content: p: count: 9 score: 1 wordValue: 0.1 formattingMultiplier: 1	1	0.9

[ 4.45 WXDAI ]

@whilefoo

Contributions Overview

View	Contribution	Count	Reward
Review	Comment	10	4.45

Conversation Incentives

Comment	Formatting	Relevance	Reward
this is not used anymore, or is it?	0.2 content: p: count: 8 score: 1 wordValue: 0.1 formattingMultiplier: 0.25	1	0.2
why do you mock 404 for merge, won't this mean the run will fail…	0.8 content: p: count: 32 score: 1 wordValue: 0.1 formattingMultiplier: 0.25	1	0.8
ideally this plugin should be at the org level config, right? bu…	0.575 content: p: count: 23 score: 1 wordValue: 0.1 formattingMultiplier: 0.25	1	0.575
btw this info is also in `Context`'s payload	0.225 content: p: count: 8 score: 1 code: count: 1 score: 1 wordValue: 0.1 formattingMultiplier: 0.25	1	0.225
you can use `octokit.rest.search.issuesAndPullRequests` …	0.225 content: p: count: 8 score: 1 code: count: 1 score: 1 wordValue: 0.1 formattingMultiplier: 0.25	1	0.225
sorry maybe I wasn't clear, you still need to use paginate, just…	0.575 content: p: count: 20 score: 1 code: count: 3 score: 1 wordValue: 0.1 formattingMultiplier: 0.25	1	0.575
wouldn't it be better to throw the error?	0.2 content: p: count: 8 score: 1 wordValue: 0.1 formattingMultiplier: 0.25	1	0.2
```suggestion const owner = payload.repository.ow…	0.525 content: pre: count: 6 score: 0 code: count: 7 score: 1 p: count: 14 score: 1 wordValue: 0.1 formattingMultiplier: 0.25	1	0.525
if `monitor` is empty do we default to checking all repo…	0.7 content: p: count: 26 score: 1 code: count: 2 score: 1 wordValue: 0.1 formattingMultiplier: 0.25	1	0.7
this plugin only works within an org so "org" is useless, and "o…	0.425 content: p: count: 17 score: 1 wordValue: 0.1 formattingMultiplier: 0.25	1	0.425

ubiquibot · 2024-08-20T10:34:20Z

@gentlementlegen the deadline is at 2024-08-21T10:34:20.261Z

0x4007 · 2024-08-20T10:34:49Z

Looks like more than four hours of work so we'll add credit

gentlementlegen added good first issue Good for newcomers Time: <4 Hours Priority: 1 (Normal) labels Jul 28, 2024

ubiquibot bot added the Price: 100 USD label Jul 28, 2024

gentlementlegen removed good first issue Good for newcomers Price: 100 USD labels Jul 28, 2024

ubiquibot bot added the Price: 100 USD label Jul 28, 2024

gentlementlegen self-assigned this Jul 28, 2024

gentlementlegen mentioned this issue Jul 28, 2024

feat!: tracking from config #4

Merged

gentlementlegen closed this as completed in #4 Aug 20, 2024

0x4007 added Time: <1 Day and removed Time: <4 Hours labels Aug 20, 2024

ubiquibot bot removed the Price: 100 USD label Aug 20, 2024

0x4007 reopened this Aug 20, 2024

ubiquibot bot added the Price: 200 USD label Aug 20, 2024

ubiquibot bot unassigned gentlementlegen Aug 20, 2024

0x4007 closed this as completed Aug 20, 2024

gentlementlegen self-assigned this Aug 20, 2024

ubiquity-os-marketplace deleted a comment from ubiquibot bot Aug 20, 2024

Change database pull-request tracking by organization configuration #2

Change database pull-request tracking by organization configuration #2

Comments

gentlementlegen commented Jul 28, 2024

ubiquibot bot commented Jul 28, 2024

ubiquibot bot commented Aug 20, 2024

ubiquityos bot commented Aug 20, 2024 • edited Loading

Contributions Overview

Conversation Incentives

Contributions Overview

Conversation Incentives

Contributions Overview

Conversation Incentives

Contributions Overview

Conversation Incentives

ubiquibot bot commented Aug 20, 2024

Contributions Overview

Conversation Incentives

### Concerns On This Approach The only thing that makes sense...

> I should always check the org it comes from I presume t...

Contributions Overview

Conversation Incentives

Contributions Overview

Conversation Incentives

@gentlementlegen I'm unsure what I'm doing wrong here. I have...

Contributions Overview

Conversation Incentives

ubiquibot bot commented Aug 20, 2024

ubiquibot bot commented Aug 20, 2024

ubiquityos bot commented Aug 20, 2024 • edited Loading

ubiquityos bot commented Aug 20, 2024 •

edited

Loading

### Concerns On This Approach
The only thing that makes sense...

> I should always check the org it comes from
I presume t...

@gentlementlegen I'm unsure what I'm doing wrong here.
I have...

ubiquityos bot commented Aug 20, 2024 •

edited

Loading