-
Notifications
You must be signed in to change notification settings - Fork 35
Boosting All Rewards Based On Priority #175
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
RFC @gentlementlegen I have a feeling that with our current infrastructure it doesn't directly support this plugin to affect the reward amount of others, such as conversation rewards. We need to support outputting rewards from all plugins and aggregating them before sending the sum total to permit generation. ubiquity-os/permit-generation#3 I suppose this proposal implies that we will need to support multiplication as well. |
Assisitive pricing aims the handle pricing labels and allowing users to modify these labels. There is not calculation on the final reward here. I think this should be handled in conversation rewards. |
I see what you mean but logically seems more straightforward if a plugin has the ability to affect all the others' pricing either with addition or multiplication. Then we don't have to change every plugin, we only need to change this one and the permit generation one to support macro change outputs from any plugin I suppose it's simpler to implement if we change every plugin though, just not as elegant. |
Yes I do agree that we should be able to chain these results. It's just that this plugin never had the capability to actually attribute rewards to a user, this was the responsibility of |
If you could write a spec, that would be helpful because I don't have enough context on the problem |
@gentlementlegen can you write the spec? |
@0x4007 Done, let me know if this is clear enough. |
Which plugin handles the final permit generation which combines all the rewards? |
/start |
Tip
|
/stop |
Right now it's Hopefully soon we can upgrade the system to make "permit requests" and every plugin will have a standardized way to send a request to the permit generation module/plugin/endpoint. |
shouldnt this spec be moved to text-conversation rewards for now for a fix and then later a better way can hopefully be found? |
@gentlementlegen rfc |
We can do that, you can also cross-reference issues from another repo, either works. |
I don't understand |
I meant doing the pull-request in |
Like how it's done for devpool directory right? |
Making a pull request to the code base while marking it to resolve the issue in the dedicated issue repo for the devpool directory |
/start |
! ishowvel you were previously unassigned from this task. You cannot be reassigned. |
+ Evaluating results. Please wait... |
Then there's a problem with this pull and how it calculates rewards. |
@0x4007 I figured out the issue, but unsure how to fix it. Long story short, the defaults take over the configuration, and the default multiplier for contributor pull request is |
+ Evaluating results. Please wait... |
! Error: Error: 429 You exceeded your current quota, please check your plan and billing details. For more information on this error, read the docs: https://platform.openai.com/docs/guides/error-codes/api-errors. |
+ Evaluating results. Please wait... |
! Error: Error: 429 You exceeded your current quota, please check your plan and billing details. For more information on this error, read the docs: https://platform.openai.com/docs/guides/error-codes/api-errors. |
@0x4007 If you can have a look at OpenAI API key, thank you. |
+ Evaluating results. Please wait... |
|
View | Contribution | Count | Reward |
---|---|---|---|
Issue | Task | 1 | 400 |
Issue | Comment | 8 | 10.17 |
Review | Comment | 29 | 0 |
Conversation Incentives
Comment | Formatting | Relevance | Priority | Reward |
---|---|---|---|---|
Which plugin handles the final permit generation which combines … | 1.95content: content: p: score: 0 elementCount: 1 result: 0 regex: wordCount: 33 wordValue: 0.1 result: 1.95 | 1 | 4 | 1.96 |
shouldnt this spec be moved to text-conversation rewards for now… | 1.49content: content: p: score: 0 elementCount: 1 result: 0 regex: wordCount: 24 wordValue: 0.1 result: 1.49 | 1 | 4 | 1.48 |
Like how it's done for devpool directory right? | 0.65content: content: p: score: 0 elementCount: 1 result: 0 regex: wordCount: 9 wordValue: 0.1 result: 0.65 | 0.5 | 4 | 0.315 |
Making a pull request to the code base while marking it to resol… | 1.49content: content: p: score: 0 elementCount: 1 result: 0 regex: wordCount: 24 wordValue: 0.1 result: 1.49 | 0.5 | 4 | 0.735 |
is there a way to qa without needing to get an openai api token | 0.94content: content: p: score: 0 elementCount: 1 result: 0 regex: wordCount: 14 wordValue: 0.1 result: 0.94 | 0 | 4 | 0.02 |
@gentlementlegen would hardcoding the evaluation to be one for e… | 1.28content: content: p: score: 0 elementCount: 2 result: 0 regex: wordCount: 20 wordValue: 0.1 result: 1.28 | 0.5 | 4 | 0.64 |
also it would very awesome if someone could make the openai impl… | 1.38content: content: p: score: 0 elementCount: 1 result: 0 regex: wordCount: 22 wordValue: 0.1 result: 1.38 | 0 | 4 | 0.02 |
https://github.com/ishowvel/text-conversation-rewards/actions/ru… | 7.4content: content: p: score: 0 elementCount: 3 a: score: 5 elementCount: 1 result: 5 regex: wordCount: 42 wordValue: 0.1 result: 2.4 | 0 | 4 | 5 |
Resolves #175 | 0content: content: p: score: 0 elementCount: 1 result: 0 regex: wordCount: 2 wordValue: 0 result: 0 | 0.1 | 4 | 0 |
The permit rewards have payouts upto 3 decimals, decimal js mult… | 0content: content: p: score: 0 elementCount: 2 result: 0 regex: wordCount: 65 wordValue: 0 result: 0 | 0.7 | 4 | 0 |
ohhhh my bad | 0content: content: p: score: 0 elementCount: 1 result: 0 regex: wordCount: 3 wordValue: 0 result: 0 | 0 | 4 | 0 |
heres the [qa](https://github.com/ishowvel-org/.ubiquity-os/issu… | 5content: content: p: score: 0 elementCount: 1 a: score: 5 elementCount: 1 result: 5 regex: wordCount: 3 wordValue: 0 result: 0 | 0.1 | 4 | 0 |
@gentlementlegen please review this 🙏 | 0content: content: p: score: 0 elementCount: 1 result: 0 regex: wordCount: 5 wordValue: 0 result: 0 | 0.1 | 4 | 0 |
After the total formatted reward is calculated, the priority lev… | 0content: content: p: score: 0 elementCount: 1 result: 0 regex: wordCount: 64 wordValue: 0 result: 0 | 0.9 | 4 | 0 |
the total itself is not multiplied but the specification and com… | 0content: content: p: score: 0 elementCount: 1 result: 0 regex: wordCount: 13 wordValue: 0 result: 0 | 0.5 | 4 | 0 |
for jest testing, no mock result has ever contained the "priorit… | 0content: content: p: score: 0 elementCount: 2 result: 0 regex: wordCount: 38 wordValue: 0 result: 0 | 0.8 | 4 | 0 |
There are 100's and 100's of results | 0content: content: p: score: 0 elementCount: 1 result: 0 regex: wordCount: 9 wordValue: 0 result: 0 | 0.1 | 4 | 0 |
https://github.com/ubiquity-os-marketplace/text-conversation-rew… | 0content: content: p: score: 0 elementCount: 1 result: 0 regex: wordCount: 18 wordValue: 0 result: 0 | 0.2 | 4 | 0 |
I am talking about the results, each result object would need to… | 0content: content: p: score: 0 elementCount: 1 result: 0 regex: wordCount: 31 wordValue: 0 result: 0 | 0.7 | 4 | 0 |
<details><summary><b><h… | 0content: content: p: score: 0 elementCount: 4 result: 0 regex: wordCount: 4 wordValue: 0 result: 0 | 0.3 | 4 | 0 |
@gentlementlegen are these the desired outputs? | 0content: content: p: score: 0 elementCount: 1 result: 0 regex: wordCount: 6 wordValue: 0 result: 0 | 0.4 | 4 | 0 |
https://github.com/ubiquity-os-marketplace/text-conversation-rew… | 0content: content: p: score: 0 elementCount: 2 result: 0 regex: wordCount: 54 wordValue: 0 result: 0 | 0.8 | 4 | 0 |
heres the new [qa](https://github.com/ishowvel-org/.ubiquity-os/… | 5content: content: p: score: 0 elementCount: 1 a: score: 5 elementCount: 1 result: 5 regex: wordCount: 25 wordValue: 0 result: 0 | 0.8 | 4 | 0 |
Done! | 0content: content: p: score: 0 elementCount: 1 result: 0 regex: wordCount: 1 wordValue: 0 result: 0 | 0.1 | 4 | 0 |
All tests that failed, failed because of not supporting this fea… | 0content: content: p: score: 0 elementCount: 1 result: 0 regex: wordCount: 20 wordValue: 0 result: 0 | 0.2 | 4 | 0 |
@gentlementlegen can you please review these changes? Thank you! | 0content: content: p: score: 0 elementCount: 1 result: 0 regex: wordCount: 9 wordValue: 0 result: 0 | 0.1 | 4 | 0 |
Any updates? | 0content: content: p: score: 0 elementCount: 1 result: 0 regex: wordCount: 2 wordValue: 0 result: 0 | 0.2 | 4 | 0 |
@0x4007 can you review this as you have created the specificatio… | 0content: content: p: score: 0 elementCount: 1 result: 0 regex: wordCount: 15 wordValue: 0 result: 0 | 0.1 | 4 | 0 |
Currently out for a university, will work on this task in a few … | 0content: content: p: score: 0 elementCount: 1 result: 0 regex: wordCount: 14 wordValue: 0 result: 0 | 0 | 4 | 0 |
idk why the tests keep failing even without the changes present … | 5content: content: p: score: 0 elementCount: 1 a: score: 5 elementCount: 1 result: 5 regex: wordCount: 32 wordValue: 0 result: 0 | 0.6 | 4 | 0 |
@gentlementlegen @octokit/core is imported, this has become a ma… | 5content: content: p: score: 0 elementCount: 1 a: score: 5 elementCount: 1 result: 5 regex: wordCount: 23 wordValue: 0 result: 0 | 0.3 | 4 | 0 |
tests even fail on a fresh clone of this repository | 0content: content: p: score: 0 elementCount: 1 result: 0 regex: wordCount: 10 wordValue: 0 result: 0 | 0.2 | 4 | 0 |
Tests are passing 🎉 🎉 🎉 | 0content: content: p: score: 0 elementCount: 1 result: 0 regex: wordCount: 3 wordValue: 0 result: 0 | 0.8 | 4 | 0 |
@gentlementlegen can you please review this | 0content: content: p: score: 0 elementCount: 1 result: 0 regex: wordCount: 6 wordValue: 0 result: 0 | 0.1 | 4 | 0 |
Do reminders exist for reviewers like the ones for assignee | 0content: content: p: score: 0 elementCount: 1 result: 0 regex: wordCount: 10 wordValue: 0 result: 0 | 0.1 | 4 | 0 |
From what I have tried using @octokit/core makes the build work … | 0content: content: p: score: 0 elementCount: 1 result: 0 regex: wordCount: 27 wordValue: 0 result: 0 | 0.4 | 4 | 0 |
My code changes do not produce this bug as you can see herehttp… | 0content: content: p: score: 0 elementCount: 1 result: 0 regex: wordCount: 36 wordValue: 0 result: 0 | 0.9 | 4 | 0 |
[ 163.844 WXDAI ]
@0x4007
Contributions Overview
View | Contribution | Count | Reward |
---|---|---|---|
Issue | Specification | 1 | 115.32 |
Issue | Comment | 8 | 44.232 |
Review | Comment | 3 | 4.292 |
Conversation Incentives
Comment | Formatting | Relevance | Priority | Reward |
---|---|---|---|---|
We should boost all the rewards proportionally if it's an urgent… | 9.61content: content: p: score: 0 elementCount: 2 h3: score: 1 elementCount: 1 a: score: 5 elementCount: 1 result: 6 regex: wordCount: 68 wordValue: 0.1 result: 3.61 | 1 | 4 | 115.32 |
RFC @gentlementlegen I have a feeling that with our current inf… | 3.75content: content: p: score: 0 elementCount: 1 result: 0 regex: wordCount: 71 wordValue: 0.1 result: 3.75 | 1 | 4 | 15 |
I see what you mean but logically seems more straightforward if … | 3.84content: content: p: score: 0 elementCount: 1 result: 0 regex: wordCount: 73 wordValue: 0.1 result: 3.84 | 1 | 4 | 15.36 |
If you could write a spec, that would be helpful because I don't… | 1.28content: content: p: score: 0 elementCount: 1 result: 0 regex: wordCount: 20 wordValue: 0.1 result: 1.28 | 0.5 | 4 | 2.56 |
@gentlementlegen can you write the spec? | 0.46content: content: p: score: 0 elementCount: 1 result: 0 regex: wordCount: 6 wordValue: 0.1 result: 0.46 | 0.5 | 4 | 0.92 |
Right now it's `text-conversation-rewards` Hopefully so… | 2content: content: p: score: 0 elementCount: 1 result: 0 regex: wordCount: 34 wordValue: 0.1 result: 2 | 0.8 | 4 | 6.4 |
@gentlementlegen rfc | 0.18content: content: p: score: 0 elementCount: 1 result: 0 regex: wordCount: 2 wordValue: 0.1 result: 0.18 | 0.3 | 4 | 0.216 |
I don't understand | 0.32content: content: p: score: 0 elementCount: 1 result: 0 regex: wordCount: 4 wordValue: 0.1 result: 0.32 | 0.2 | 4 | 0.256 |
Then there's a problem with this pull and how it calculates rewa… | 0.88content: content: p: score: 0 elementCount: 1 result: 0 regex: wordCount: 13 wordValue: 0.1 result: 0.88 | 1 | 4 | 3.52 |
Just copy the priority level names? Our config is public you can… | 1.22content: content: p: score: 0 elementCount: 1 result: 0 regex: wordCount: 19 wordValue: 0.1 result: 1.22 | 0.6 | 4 | 2.928 |
There's five priority levels | 0.39content: content: p: score: 0 elementCount: 1 result: 0 regex: wordCount: 5 wordValue: 0.1 result: 0.39 | 0.3 | 4 | 0.468 |
I guess 3x multiplier? | 0.32content: content: p: score: 0 elementCount: 1 result: 0 regex: wordCount: 4 wordValue: 0.1 result: 0.32 | 0.7 | 4 | 0.896 |
[ 154.412 WXDAI ]
@gentlementlegen
Contributions Overview
View | Contribution | Count | Reward |
---|---|---|---|
Issue | Comment | 10 | 34 |
Review | Comment | 14 | 120.412 |
Conversation Incentives
Comment | Formatting | Relevance | Priority | Reward |
---|---|---|---|---|
Assisitive pricing aims the handle pricing labels and allowing u… | 1.9content: content: p: score: 0 elementCount: 1 result: 0 regex: wordCount: 32 wordValue: 0.1 result: 1.9 | 0.5 | 4 | 3.8 |
Yes I do agree that we should be able to chain these results. It… | 2.69content: content: p: score: 0 elementCount: 1 result: 0 regex: wordCount: 48 wordValue: 0.1 result: 2.69 | 1 | 4 | 10.76 |
@0x4007 Done, let me know if this is clear enough. | 0.71content: content: p: score: 0 elementCount: 1 result: 0 regex: wordCount: 10 wordValue: 0.1 result: 0.71 | 0 | 4 | 0 |
We can do that, you can also cross-reference issues from another… | 1content: content: p: score: 0 elementCount: 1 result: 0 regex: wordCount: 15 wordValue: 0.1 result: 1 | 0.3 | 4 | 1.2 |
I meant doing the pull-request in `text-conversation-rewards… | 0.77content: content: p: score: 0 elementCount: 1 result: 0 regex: wordCount: 11 wordValue: 0.1 result: 0.77 | 0.4 | 4 | 1.232 |
@ishowvel You can either use a free endpoint, use mocks, or hard… | 1.11content: content: p: score: 0 elementCount: 1 result: 0 regex: wordCount: 17 wordValue: 0.1 result: 1.11 | 0 | 4 | 0 |
@ishowvel You can check the tests where the evaluation is mocked… | 2.73content: content: p: score: 0 elementCount: 2 result: 0 regex: wordCount: 49 wordValue: 0.1 result: 2.73 | 0 | 4 | 0 |
@ishowvel I had to delete this because the bot seems to wrongly … | 1.7content: content: p: score: 0 elementCount: 1 result: 0 regex: wordCount: 28 wordValue: 0.1 result: 1.7 | 1 | 4 | 6.8 |
@0x4007 I figured out the issue, but unsure how to fix it. Long … | 2.2content: content: p: score: 0 elementCount: 1 result: 0 regex: wordCount: 38 wordValue: 0.1 result: 2.2 | 1 | 4 | 8.8 |
@0x4007 If you can have a look at OpenAI API key, thank you. | 0.88content: content: p: score: 0 elementCount: 1 result: 0 regex: wordCount: 13 wordValue: 0.1 result: 0.88 | 0.4 | 4 | 1.408 |
Please use `octokit` types. | 0.25content: content: p: score: 0 elementCount: 1 result: 0 regex: wordCount: 3 wordValue: 0.1 result: 0.25 | 0.6 | 4 | 0.6 |
Why cutting to 3 decimals?I did make a comment about the float… | 1.8content: content: p: score: 0 elementCount: 2 result: 0 regex: wordCount: 30 wordValue: 0.1 result: 1.8 | 0.7 | 4 | 5.04 |
Yes that is why we use DecimalJs so `0.1 + 0.2` will yie… | 1.65content: content: p: score: 0 elementCount: 1 result: 0 regex: wordCount: 27 wordValue: 0.1 result: 1.65 | 0.8 | 4 | 5.28 |
@ishowvel You should add `Jest` tests to your pull-reque… | 7.1content: content: p: score: 0 elementCount: 4 img: score: 5 elementCount: 1 result: 5 regex: wordCount: 36 wordValue: 0.1 result: 2.1 | 0.9 | 4 | 27.56 |
@ishowvel try with priority 3 as it is the most likely to give v… | 13.92content: content: p: score: 0 elementCount: 7 img: score: 5 elementCount: 2 result: 10 regex: wordCount: 75 wordValue: 0.1 result: 3.92 | 0.8 | 4 | 52.544 |
@0x4007 Sure but `3.504 * 3 = 10.512` so I don't underst… | 0.88content: content: p: score: 0 elementCount: 1 result: 0 regex: wordCount: 13 wordValue: 0.1 result: 0.88 | 0.7 | 4 | 2.464 |
Because every module can be disabled individually, the type can … | 2.2content: content: p: score: 0 elementCount: 1 result: 0 regex: wordCount: 38 wordValue: 0.1 result: 2.2 | 0.5 | 4 | 4.4 |
New QA is ok: https://github.com/Meniole/text-conversation-rewar… | 2.69content: content: p: score: 0 elementCount: 2 result: 0 regex: wordCount: 48 wordValue: 0.1 result: 2.69 | 0.7 | 4 | 7.532 |
@ishowvel Sorry I have been extremely busy yes, I'll try to have… | 1.44content: content: p: score: 0 elementCount: 1 result: 0 regex: wordCount: 23 wordValue: 0.1 result: 1.44 | 0.4 | 4 | 2.304 |
@ishowvel tests don't pass because the import types don't match,… | 1.44content: content: p: score: 0 elementCount: 1 result: 0 regex: wordCount: 23 wordValue: 0.1 result: 1.44 | 0.6 | 4 | 3.456 |
@ishowvel merge the development branch into this one. | 0.59content: content: p: score: 0 elementCount: 1 result: 0 regex: wordCount: 8 wordValue: 0.1 result: 0.59 | 0.5 | 4 | 1.18 |
@ishowvel I tried to run the plugin with your pull-request and t… | 2.2content: content: p: score: 0 elementCount: 3 result: 0 regex: wordCount: 38 wordValue: 0.1 result: 2.2 | 0.6 | 4 | 5.28 |
@ishowvel Okay let me try to fix the test and build then. | 0.83content: content: p: score: 0 elementCount: 1 result: 0 regex: wordCount: 12 wordValue: 0.1 result: 0.83 | 0.3 | 4 | 0.996 |
Seems to be ok in my latest QA: https://github.com/Meniole/text-… | 1.11content: content: p: score: 0 elementCount: 1 result: 0 regex: wordCount: 17 wordValue: 0.1 result: 1.11 | 0.4 | 4 | 1.776 |
Uh oh!
There was an error while loading. Please reload this page.
We should boost all the rewards proportionally if it's an urgent task. This will incentivize all contributors (not just the assignee) to focus on that task because everybody gets higher rewards for work like reviews.
The higher the priority level the higher the rewards multiplier is for everybody.
example
I should've received a reward closer to $150 in this task, because the priority level was 3.
The text was updated successfully, but these errors were encountered: