-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Package and GitHub agnostic option #5
Comments
In the vision I propose about summing payment requests, this means that a permit will only be generated in this plugin, not inside of other plugins. I don't think this task is necessary. |
@pavlovcik This is aimed to help for ubiquity-os-marketplace/text-conversation-rewards#5 or if eventually we want it to be ran by the kernel itself, related to our discussion |
I replied and definitely think this is not a task worth pursing. |
# Issue was not closed as completed. Skipping. |
If you want to implement this as a temporary solution, i.e. tech debt, then perhaps it makes sense so that we can get back on track with our schedule. |
! No price label has been set. Skipping permit generation. |
+ Evaluating results. Please wait... |
We got rate limited https://github.com/ubiquibot/comment-incentives/actions/runs/8617933701/job/23619113189 Seems like this can be a problem as we pick up on activity in our network. |
|
View | Contribution | Count | Reward |
---|---|---|---|
Issue | Comment | 4 | 17 |
Review | Comment | 2 | 8.3 |
Conversation Incentives
Comment | Formatting | Relevance | Reward |
---|---|---|---|
1. Be sure to provide a time estimate 2. What's the motivation?... | 8.7li: count: 2 score: "2" words: 33 | 0.21 | 8.7 |
I replied and definitely think this is not a task worth pursing.... | 1.2 | 0.22 | 1.2 |
If you want to implement this as a temporary solution, i.e. tech... | 3 | 0.32 | 3 |
> ```diff > + Evaluating results. Please wait... > ```We g... | 4.1code: count: 1 score: "1" words: 0 | 0.17 | 4.1 |
I don't have time to look through code, and will instead focus o... | 7.9a: count: 1 score: "1" words: 2 | 0.4 | 7.9 |
Knip: the Sisyphusian task ... | 0.4 | 0.35 | 0.4 |
[ 142.4 WXDAI ]
@gentlementlegen
Contributions Overview
View | Contribution | Count | Reward |
---|---|---|---|
Issue | Specification | 1 | 22.6 |
Issue | Task | 1 | 50 |
Issue | Comment | 1 | 7.4 |
Issue | Comment | 1 | 0 |
Review | Comment | 3 | 41.6 |
Review | Comment | 3 | 20.8 |
Conversation Incentives
Comment | Formatting | Relevance | Reward |
---|---|---|---|
The package is usable as a GitHub action but does not offer any ... | 22.6li: count: 3 score: "3" words: 24 code: count: 1 score: "1" words: 2 | 1 | 22.6 |
@pavlovcik This is aimed to help for https://github.com/ubiquibo... | 7.4a: count: 1 score: "1" words: 1 | 0.36 | 7.4 |
@pavlovcik This is aimed to help for https://github.com/ubiquibo... | -a: count: 1 score: "0" words: 1 | 0.36 | - |
`NPM_TOKEN` would be needed in the env to properly publish the p... | 15.6code: count: 2 score: "4" words: 2 | 0.58 | 15.6 |
@pavlovcik yep I agree. This library will simply allow us to mov... | 14.8code: count: 1 score: "2" words: 3 | 0.82 | 14.8 |
> Knip kung-fu and Jest tests green (tests passing on branch loc... | 11.2code: count: 2 score: "4" words: 2 | 0.595 | 11.2 |
`NPM_TOKEN` would be needed in the env to properly publish the p... | 7.8code: count: 2 score: "2" words: 2 | 0.58 | 7.8 |
@pavlovcik yep I agree. This library will simply allow us to mov... | 7.4code: count: 1 score: "1" words: 3 | 0.82 | 7.4 |
> Knip kung-fu and Jest tests green (tests passing on branch loc... | 5.6code: count: 2 score: "2" words: 2 | 0.595 | 5.6 |
[ 26.7 WXDAI ]
@gitcoindev
Contributions Overview
View | Contribution | Count | Reward |
---|---|---|---|
Review | Comment | 8 | 26.7 |
Conversation Incentives
Comment | Formatting | Relevance | Reward |
---|---|---|---|
I noticed Knip is failing in this repo, I will fix this today.... | 1.3 | 0.79 | 1.3 |
I fixed Knip configuration and opened an another pull request, s... | 6 | 0.865 | 6 |
@gentlementlegen as expected after merging there are a few confl... | 3.7 | 0.665 | 3.7 |
I found a few issues and fixed them, it complains about jest typ... | 2.5 | 0.53 | 2.5 |
Knip kung-fu and Jest tests green (tests passing on branch local... | 3.7 | 0.48 | 3.7 |
> > Knip kung-fu and Jest tests green (tests passing on branch l... | 4.4code: count: 2 score: "2" words: 2 | 0.61 | 4.4 |
@gentlementlegen I fixed tests, had to add explicit imports and ... | 5 | 0.66 | 5 |
> Knip: the Sisyphusian task![myths-legends-greek-greek_myth... | 0.1 | 0.07 | 0.1 |
I triggered once more in debug mode, will not spam anymore here -) |
The package is usable as a GitHub action but does not offer any option to be directly imported in the code of another project.
Having it as a NPM Package would greatly facitate integration within other projects without the hassle of importing submodules, or using Actions.
The package should also offer an option to be GitHub Action agnostic, because its purpose is simply to generate permits.
Tasks to be carried on:
.d.ts
filesThe text was updated successfully, but these errors were encountered: