Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Private Only Tasks #20

Closed
0x4007 opened this issue Mar 8, 2024 · 9 comments
Closed

Private Only Tasks #20

0x4007 opened this issue Mar 8, 2024 · 9 comments

Comments

@0x4007
Copy link
Member

0x4007 commented Mar 8, 2024

https://github.com/ubiquity/devpool-directory-private is our new "backend" to read private issues and populate them on the devpool.directory

This should ONLY populate with private repository issues. This is so we don't have redundant data on the public and private directories.

Also re-enable "referencing" back to private repository issues (I just disabled it entirely in that repo as a quick fix by disabling the logic if its not the public devpool-directory repo https://github.com/ubiquity/devpool-directory-private/blob/development/helpers/github.ts#L63.) This means that the bot should paste in the normal URL in the GitHub comment so that the mirrored issue is "referenced" in the real issue conversation.

Ensure that this works as expected by testing the UI on the devpool.directory (you must auth as a core team member)

@0x4007 0x4007 changed the title Clean Up Private Directory Private Only Tasks Mar 8, 2024
@rndquu
Copy link
Member

rndquu commented Mar 9, 2024

Perhaps we need some github env variable like READ_ISSUES_MODE=public|private which should be public for https://github.com/ubiquity/devpool-directory and private for https://github.com/ubiquity/devpool-directory-private

@jordan-ae
Copy link

/start

Copy link

ubiquibot bot commented Mar 25, 2024

@okhot the deadline is at 2024-03-25T16:57:41.799Z

@jordan-ae
Copy link

@pavlovcik To ensure this is working correctly I have to Auth as a core member. Please how can I archive that as I presently don't know how to do so.

@rndquu
Copy link
Member

rndquu commented Mar 27, 2024

This should ONLY populate with private repository issues.

https://github.com/ubiquity/devpool-directory-private/blob/development/opt.json already contains only private repositories, I don't understand what additional checks should be implemented

I just disabled it entirely in that repo as a quick fix by disabling the logic if its not the public devpool-directory repo https://github.com/ubiquity/devpool-directory-private/blob/development/helpers/github.ts#L63

I think this quick fix is already removed (I remember there was some check for organization name) but I couldn't find the exact commit

@jordan-ae
Copy link

@rndquu then there's no need for this issue to exist then?

@jordan-ae
Copy link

/stop

Copy link

ubiquibot bot commented Mar 28, 2024

+ You have been unassigned from the task

@rndquu
Copy link
Member

rndquu commented Oct 8, 2024

This issue may be closed as "not planned" because:

  1. https://github.com/ubiquity/devpool-directory-private/blob/development/opt.json already contains only private repositories (except for https://github.com/ubiquity/card-issuance which is public now but used to be private, not sure whether it should be public or private)
  2. "referencing back to private repository issues" works as expected (check Bounty proposal: integrate Reloadly API card-issuance#34 which has a reference to devpool-directory-private)
Screenshot 2024-10-08 at 18 37 54

Overall it makes sense to setup code sync between devpool-directory and devpool-directory-private to make both code bases consistent.

@0x4007 0x4007 closed this as not planned Won't fix, can't repro, duplicate, stale Oct 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants