Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Close Assigned Issues #23

Closed
0x4007 opened this issue Mar 25, 2024 · 38 comments · Fixed by ubiquity/devpool-directory#1159
Closed

Close Assigned Issues #23

0x4007 opened this issue Mar 25, 2024 · 38 comments · Fixed by ubiquity/devpool-directory#1159

Comments

@0x4007
Copy link
Member

0x4007 commented Mar 25, 2024

We do not want assigned issues to render on work.ubq.fi

The simple solution would be to close them (that way they would not be categorized as an "open" task)

The more complex solution would be to have special logic in the UI for the unavailable label but I feel that closing as not planned might be better? Then we can close as complete if it is actually closed as complete?

However, the original issue was resolved according to the spec here and that was just to remove the unavailable bounties from the devpool repo was it not?

You're right. I read the following as "closing" the issue which means that it would not render in the work.ubq.fi UI

if bounty is unavailable (i.e. assigned to some bounty hunter) and exists in the list with the state open then close such bounty

With an emphasis on

then close such bounty

So we need to file a new issue and get a new pull request to actually close them?

Originally posted by @pavlovcik in #11 (comment)

@Keyrxng
Copy link

Keyrxng commented Mar 25, 2024

see #11 (comment)

  • rndquu was laying the way for removing the unavailable label completely at least that's the direction I was being pushed with hiding the unavailable bounties from the devpool

@0x4007
Copy link
Member Author

0x4007 commented Mar 25, 2024

I don't understand what you're saying but this still remains an active issue.

This one is on the directory and is currently assigned: https://www.github.com/ubiquity/pay.ubq.fi/issues/196

@jordan-ae
Copy link

@pavlovcik is this available to work on?

@Keyrxng
Copy link

Keyrxng commented Mar 25, 2024

@okhot just do /start so no one takes it first buddy, this is available tho I was going to grab it myself but gl with it

I don't understand what you're saying

I was referring to the removal of the unavailable labels from the devpool

The more complex solution would be to have special logic in the UI for the unavailable label

This seems backwards if those labels are being removed

@jordan-ae
Copy link

@Keyrxng thanks

@jordan-ae
Copy link

/start

Copy link

ubiquibot bot commented Mar 25, 2024

! Too many assigned issues, you have reached your max limit

@jordan-ae
Copy link

Didn't notice I got assigned the other bounties 😅. Thanks I'll pass on this one

@gentlementlegen
Copy link
Member

@pavlovcik Wouldn't it be easier to have this handled directly via the fetching step inside of work.ubq.fi? Seems more like a visual change with filtering rather than changing logic inside of here.

@0x4007
Copy link
Member Author

0x4007 commented Mar 25, 2024

The simple solution would be to close them (that way they would not be categorized as an "open" task)

Seems more intuitive for me to implement across all tooling that interacts with the data, which includes the statistics calculation json within this repo that is intended to be displayed on ubq.fi

I don't feel that the unavailable label is the right approach

@Ekep-Obasi
Copy link

Hi @Keyrxng, I'd like to give this a shot

@Ekep-Obasi
Copy link

/start

Copy link

ubiquibot bot commented Mar 26, 2024

! action has an uncaught error

@gentlementlegen
Copy link
Member

gentlementlegen commented Mar 26, 2024

The simple solution would be to close them (that way they would not be categorized as an "open" task)

Seems more intuitive for me to implement across all tooling that interacts with the data, which includes the statistics calculation json within this repo that is intended to be displayed on ubq.fi

I don't feel that the unavailable label is the right approach

If for some reason tomorrow we wanted to display these tasks and add a sorting parameter about them, we should revert this. To me it comes as simple as filtering out issues that have an assignee, which is straightforward and requires only one line of code change in work.ubq.fi

Edit: I noticed in the devpool that no one is assigned on the issues, which doesn't allow for sorting by assignee. Maybe actually assigning someone to the issues could be a solution, so we can directly sort using GitHub API?

@0x4007
Copy link
Member Author

0x4007 commented Mar 26, 2024

It's not possible unless they are added to the org/repo as a collaborator I already looked into that. Please let's just go with the spec.

Copy link

ubiquibot bot commented Mar 26, 2024

@Ekep-Obasi the deadline is at 2024-03-26T11:06:41.592Z

@0x4007
Copy link
Member Author

0x4007 commented Mar 26, 2024

/start

You need to set your wallet address @Ekep-Obasi

Also for obvious reasons we don't allow people to make multiple GitHub accounts just to get around assign limits. You will be unassigned if things aren't getting done in time.

In addition if anybody frontruns the delivery on this I would credit them as this is an emergency task

@Keyrxng
Copy link

Keyrxng commented Mar 26, 2024

Would that be bad karma for the frontrunner? 😂

@gitcoindev
Copy link

we don't allow people to make multiple GitHub accounts just to get around assign limits

An interesting concept to game the system, if one can type fast 😂

@jordan-ae
Copy link

jordan-ae commented Mar 26, 2024

We're not the same person 😅 he's my brother though. We have similar names. It's from the git history that we're different people. Changed my git name to make it less similar

@0x4007
Copy link
Member Author

0x4007 commented Mar 26, 2024

Would that be bad karma for the frontrunner? 😂

We don't have it formalized but I think that high priority (emergency) tasks should be free-for-all because we need it done at any costs, figuratively speaking.

@Ekep-Obasi
Copy link

/wallet 0x6665c09B7473bd174329B93C13281D1B902bA053

Copy link

ubiquibot bot commented Mar 27, 2024

! action has an uncaught error

@rndquu
Copy link
Member

rndquu commented Mar 27, 2024

@pavlovcik This feature (if partner issue is assigned then it will be closed in devpool) is already implemented, we see assigned issues at https://work.ubq.fi/ because of #22

@gentlementlegen
Copy link
Member

/query Ekep-Obasi

Copy link

ubiquibot bot commented Mar 27, 2024

- Invalid body for query command 
-  usage /query @user

@gentlementlegen
Copy link
Member

/query @Ekep-Obasi

Copy link

ubiquibot bot commented Mar 27, 2024

Property Value
Wallet 0x6665c09B7473bd174329B93C13281D1B902bA053

@0x4007
Copy link
Member Author

0x4007 commented Mar 28, 2024

@pavlovcik This feature (if partner issue is assigned then it will be closed in devpool) is already implemented, we see assigned issues at https://work.ubq.fi/ because of #22

I'm at the conference so I can't efficiently handle novel situations. What should we do here?

@Keyrxng
Copy link

Keyrxng commented Mar 28, 2024

What should we do here?

@0x4007
Copy link
Member Author

0x4007 commented Apr 4, 2024

@rndquu would you be able to address this?

@rndquu
Copy link
Member

rndquu commented Apr 12, 2024

@rndquu would you be able to address this?

Already addressed in ubiquity/devpool-directory#1159 and ubiquity/devpool-directory#1158

@Keyrxng
Copy link

Keyrxng commented Apr 25, 2024

@rndquu should this be closed as not-planned then considering it's already been handled by yourself and in my test coverage PR?

And a new issue should be opened for improving test coverage specifically, or should this be closed as complete with the merging of my PR?

Copy link

ubiquibot bot commented Apr 25, 2024

! action has an uncaught error

@0x4007 0x4007 assigned Keyrxng and unassigned Ekep-Obasi Apr 25, 2024
Copy link

ubiquibot bot commented Apr 25, 2024

@Keyrxng the deadline is at 2024-04-25T16:06:41.356Z

@0x4007 0x4007 reopened this Apr 25, 2024
@0x4007 0x4007 closed this as completed Apr 25, 2024
Copy link

ubiquibot bot commented Apr 25, 2024

# These linked pull requests are closed:  <a href="https://github.com/ubiquity/devpool-directory/pull/1159">#1159</a>  <a href="https://github.com/ubiquity/devpool-directory/pull/1157">#1157</a> 

Copy link

ubiquibot bot commented Apr 25, 2024

+ Evaluating results. Please wait...

Copy link

ubiquibot bot commented Apr 25, 2024

[ 61 WXDAI ]

@0x4007
Contributions Overview
ViewContributionCountReward
IssueSpecification116.4
IssueComment744.6
Conversation Incentives
CommentFormattingRelevanceReward
We do not want assigned issues to render on work.ubq.fi

The ...

16.4

code:
  count: 2
  score: "2"
  words: 2
116.4
I don't understand what you're saying but this still remains an ...
70.17
> The simple solution would be to close them (that way they woul...
90.69
It's not possible unless they are added to the org/repo as a col...
5.60.615.6
> /start

You need to set your wallet address @Ekep-Obasi

Also...

120.6312
> Would that be bad karma for the frontrunner? 😂

We don't ha...

5.80.345.8
> @pavlovcik This feature (if partner issue is assigned then it ...
3.60.573.6
@rndquu would you be able to address this?...
1.60.471.6

[ 14.7 WXDAI ]

@gentlementlegen
Contributions Overview
ViewContributionCountReward
IssueComment214.7
Conversation Incentives
CommentFormattingRelevanceReward
@pavlovcik Wouldn't it be easier to have this handled directly v...
4.5
code:
  count: 1
  score: "1"
  words: 3
0.594.5
> > The simple solution would be to close them (that way they wo...
10.2
code:
  count: 1
  score: "1"
  words: 3
0.610.2

[ 6 WXDAI ]

@jordan-ae
Contributions Overview
ViewContributionCountReward
IssueComment46
Conversation Incentives
CommentFormattingRelevanceReward
@pavlovcik is this available to work on?...
0.70.250.7
@Keyrxng thanks ...
0.20.420.2
Didn't notice I got assigned the other bounties 😅. Thanks I'll ...
1.60.571.6
We're not the same person 😅 he's my brother though. We have sim...
3.50.423.5

[ 1.2 WXDAI ]

@gitcoindev
Contributions Overview
ViewContributionCountReward
IssueComment11.2
Conversation Incentives
CommentFormattingRelevanceReward
> we don't allow people to make multiple GitHub accounts just to...
1.20.551.2

[ 250 WXDAI ]

@Keyrxng
Contributions Overview
ViewContributionCountReward
IssueTask1250
IssueComment50
Conversation Incentives
CommentFormattingRelevanceReward
see https://github.com/ubiquity/devpool-directory-bounties/issue...
-
li:
  count: 1
  score: "0"
  words: 33
code:
  count: 2
  score: "0"
  words: 2
0.41-
@okhot just do `/start` so no one takes it first buddy, this is ...
-
code:
  count: 2
  score: "0"
  words: 2
0.61-
Would that be bad karma for the frontrunner? 😂...
-0.48-
> What should we do here?
-
li:
  count: 1
  score: "0"
  words: 15
0.6-
@rndquu should this be closed as not-planned then considering it...
-0.59-

[ 1 WXDAI ]

@Ekep-Obasi
Contributions Overview
ViewContributionCountReward
IssueComment11
Conversation Incentives
CommentFormattingRelevanceReward
Hi @Keyrxng, I'd like to give this a shot...
10.681

[ 5.8 WXDAI ]

@rndquu
Contributions Overview
ViewContributionCountReward
IssueComment25.8
Conversation Incentives
CommentFormattingRelevanceReward
@pavlovcik This feature (if partner issue is assigned then it wi...
3.80.593.8
> @rndquu would you be able to address this?

Already addresse...

20.532

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment