Skip to content
This repository has been archived by the owner on Oct 27, 2024. It is now read-only.

Deploy issue on Development #12

Closed
0x4007 opened this issue Dec 7, 2023 · 7 comments
Closed

Deploy issue on Development #12

0x4007 opened this issue Dec 7, 2023 · 7 comments

Comments

@0x4007
Copy link
Member

0x4007 commented Dec 7, 2023

I just realized that the deployments only work from the main branch. According to our template, it will automatically deploy to Cloudflare pages on development anyways.

If I recall correctly, we simply need to move index.html to static/index.html for our template Cloudflare uploader to work?

Screenshot 2023-12-08 at 01 38 08
@0x4007
Copy link
Member Author

0x4007 commented Dec 7, 2023

@rndquu rfc

It isn't clear to me how you got it to work only on main

Looks like more assets are being uploaded to main deploys only:
Screenshot 2023-12-08 at 01 40 41

Compared to development

Screenshot 2023-12-08 at 01 41 05

I briefly looked through the GitHub Actions and nothing stands out to me why or how it could be misconfigured.

@rndquu
Copy link
Member

rndquu commented Dec 10, 2023

I'll check it today

@rndquu
Copy link
Member

rndquu commented Dec 11, 2023

The development branch seems to be deployed.

  1. I've merged this PR into the development branch
  2. Build workflow run successfully
  3. Cloudflare pages deploy workflow also run successfully and deployed logger at https://6fc3daaa.ubiquibot-logging.pages.dev/

You're referring to https://317bb11c.ubiquibot-logging.pages.dev/ to be the latest build from the development branch but I don't really understand where Hello, world! is taken from, perhaps from some old build. Pls check the latest deployments in your cloudflare accounts, both main and development branches should be deployed.

@0x4007
Copy link
Member Author

0x4007 commented Dec 12, 2023

The development branch seems to be deployed.

  1. I've merged this PR into the development branch
  2. Build workflow run successfully
  3. Cloudflare pages deploy workflow also run successfully and deployed logger at https://6fc3daaa.ubiquibot-logging.pages.dev/

You're referring to https://317bb11c.ubiquibot-logging.pages.dev/ to be the latest build from the development branch but I don't really understand where Hello, world! is taken from, perhaps from some old build. Pls check the latest deployments in your cloudflare accounts, both main and development branches should be deployed.

"Hello, world!" is generated on the Cloudflare side if it does not find any files. I checked our other projects to confirm this.

@rndquu
Copy link
Member

rndquu commented Dec 12, 2023

The development branch seems to be deployed.

  1. I've merged this PR into the development branch
  2. Build workflow run successfully
  3. Cloudflare pages deploy workflow also run successfully and deployed logger at https://6fc3daaa.ubiquibot-logging.pages.dev/

You're referring to https://317bb11c.ubiquibot-logging.pages.dev/ to be the latest build from the development branch but I don't really understand where Hello, world! is taken from, perhaps from some old build. Pls check the latest deployments in your cloudflare accounts, both main and development branches should be deployed.

"Hello, world!" is generated on the Cloudflare side if it does not find any files. I checked our other projects to confirm this.

Is logger app successfully deployed from the development branch in cloudflare pages right now? It should be. I don't have access to ubiquity's CF account so it's hard to debug.

@0x4007
Copy link
Member Author

0x4007 commented Jan 23, 2024

Seems like its working fine. I just checked the latest CI run and it seems to work.

@0x4007 0x4007 closed this as completed Jan 23, 2024
Copy link

ubiquibot bot commented Jan 23, 2024

! No price label has been set. Skipping permit generation.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants