From 27749381b19b1c9f96e0b37d981a3197b47b5554 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?=E3=82=A2=E3=83=AC=E3=82=AF=E3=82=B5=E3=83=B3=E3=83=80?= =?UTF-8?q?=E3=83=BC=2Eeth?= Date: Fri, 4 Oct 2024 07:31:30 +0900 Subject: [PATCH] refactor: cleanup --- src/home/authentication.ts | 2 -- src/home/home.ts | 15 ++++++--------- src/home/rendering/render-github-issues.ts | 18 ------------------ 3 files changed, 6 insertions(+), 29 deletions(-) diff --git a/src/home/authentication.ts b/src/home/authentication.ts index 0cbf3ddb..4e8fb1ae 100644 --- a/src/home/authentication.ts +++ b/src/home/authentication.ts @@ -4,7 +4,6 @@ import { getGitHubUser } from "./getters/get-github-user"; import { GitHubUser } from "./github-types"; import { displayGitHubUserInformation } from "./rendering/display-github-user-information"; import { renderGitHubLoginButton } from "./rendering/render-github-login-button"; -// import { viewToggle } from "./fetch-github/fetch-and-display-previews"; export async function authentication() { const accessToken = await getGitHubAccessToken(); @@ -16,6 +15,5 @@ export async function authentication() { if (gitHubUser) { trackDevRelReferral(gitHubUser.login + "|" + gitHubUser.id); await displayGitHubUserInformation(gitHubUser); - // viewToggle.disabled = false; } } diff --git a/src/home/home.ts b/src/home/home.ts index 711de787..259370bf 100644 --- a/src/home/home.ts +++ b/src/home/home.ts @@ -6,19 +6,19 @@ import { fetchIssuesFull } from "./fetch-github/fetch-issues-full"; import { readyToolbar } from "./ready-toolbar"; import { registerServiceWorker } from "./register-service-worker"; import { renderServiceMessage } from "./render-service-message"; -// import { renderErrorInModal } from "./rendering/display-popup-modal"; +import { renderErrorInModal } from "./rendering/display-popup-modal"; import { renderGitRevision } from "./rendering/render-github-login-button"; import { generateSortingToolbar } from "./sorting/generate-sorting-buttons"; import { TaskManager } from "./task-manager"; // All unhandled errors are caught and displayed in a modal -// window.addEventListener("error", (event: ErrorEvent) => renderErrorInModal(event.error)); +window.addEventListener("error", (event: ErrorEvent) => renderErrorInModal(event.error)); // All unhandled promise rejections are caught and displayed in a modal -// window.addEventListener("unhandledrejection", (event: PromiseRejectionEvent) => { -// renderErrorInModal(event.reason as Error); -// event.preventDefault(); -// }); +window.addEventListener("unhandledrejection", (event: PromiseRejectionEvent) => { + renderErrorInModal(event.reason as Error); + event.preventDefault(); +}); renderGitRevision(); initiateDevRelTracking(); @@ -46,8 +46,5 @@ void (async function home() { registerServiceWorker(); } - // if (!container.childElementCount) { - // applyAvatarsToIssues(); - // } return gitHubIssues; })(); diff --git a/src/home/rendering/render-github-issues.ts b/src/home/rendering/render-github-issues.ts index ba2f6b99..0712fc45 100644 --- a/src/home/rendering/render-github-issues.ts +++ b/src/home/rendering/render-github-issues.ts @@ -37,24 +37,6 @@ function everyNewIssue({ gitHubIssue, container }: { gitHubIssue: GitHubIssue; c issueElement.setAttribute("data-issue-id", gitHubIssue.id.toString()); issueElement.classList.add("issue-element-inner"); - // const urlPattern = /https:\/\/github\.com\/([^/]+)\/([^/]+)\//; - // if (!gitHubIssue.body) { - // console.warn(`No body found for issue ${gitHubIssue.id}.`); - // return; - // } - // const match = gitHubIssue.body.match(urlPattern); - // const organizationName = match?.[1]; - - // if (!organizationName) { - // console.warn(`No organization name found for issue ${gitHubIssue.id}.`); - // return; - // } - - // const repositoryName = match?.[2]; - // if (!repositoryName) { - // console.warn("No repository name found"); - // return; - // } const labels = parseAndGenerateLabels(gitHubIssue); const [organizationName, repositoryName] = gitHubIssue.repository_url.split("/").slice(-2); setUpIssueElement(issueElement, gitHubIssue, organizationName, repositoryName, labels, gitHubIssue.html_url);