Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New Cache Schema #6

Closed
0x4007 opened this issue Jan 25, 2024 · 17 comments · Fixed by #7
Closed

New Cache Schema #6

0x4007 opened this issue Jan 25, 2024 · 17 comments · Fixed by #7

Comments

@0x4007
Copy link
Member

0x4007 commented Jan 25, 2024

Draft

There's several properties we must associate with issues in the context of displaying them correctly.

  1. origin - where the issue was loaded from localStorage | octokit
    • Any octokit origin issue (freshly loaded from the API) should have a visual indicator as being "new"
  2. fullIssueId - we only load issue previews from @ubiquity/devpool-directory/issues and we need to associate the preview issue ID to the "full" issue ID that it points to.
  • I also think that we should immediately display from cache first, and then fetch updates in the background.
  • If an issue is no longer present according to octokit, we need to sync our localStorage (remove the issue) so that it does not display anymore.
@0x4007 0x4007 linked a pull request Jan 29, 2024 that will close this issue
@0x4007 0x4007 closed this as completed Jan 29, 2024
Copy link

ubiquibot bot commented Jan 29, 2024

! No price label has been set. Skipping permit generation.

@0x4007
Copy link
Member Author

0x4007 commented Jan 29, 2024

(testing)

@0x4007 0x4007 closed this as completed Jan 29, 2024
Copy link

ubiquibot bot commented Jan 29, 2024

! action has an uncaught error

Copy link

ubiquibot bot commented Jan 29, 2024

+ Evaluating results. Please wait...

Copy link

ubiquibot bot commented Jan 29, 2024

! action has an uncaught error

Copy link

ubiquibot bot commented Jan 29, 2024

+ Evaluating results. Please wait...

@0x4007 0x4007 reopened this Jan 29, 2024
@0x4007
Copy link
Member Author

0x4007 commented Jan 29, 2024

It doesn't remove issues from the UI that are no longer being returned by the GitHub API.

@kamaalsultan
Copy link

@pavlovcik what about this issue?

@kamaalsultan
Copy link

/start

Copy link

ubiquibot bot commented Jan 30, 2024

DeadlineWed, Jan 31, 12:51 PM UTC
Registered Wallet 0xeFeF11577Db8f882F6Bf92F46008170Ba3602D40
Tips:
  • Use /wallet 0x0000...0000 if you want to update your registered payment wallet address.
  • Be sure to open a draft pull request as soon as possible to communicate updates on your progress.
  • Be sure to provide timely updates to us when requested, or you will be automatically unassigned from the task.

@kamaalsultan
Copy link

/wallet 0xD120be98F0301b7079C8FD1B1d7041f5219A648C

Copy link

ubiquibot bot commented Jan 30, 2024

+ Successfully registered wallet address

@kamaalsultan
Copy link

/wallet 0x55E4584211005429873f5D176AFA8B0b42B54744

Copy link

ubiquibot bot commented Jan 30, 2024

+ Successfully registered wallet address

@0x4007
Copy link
Member Author

0x4007 commented Jan 30, 2024

Hey sorry @ByteBallet @wannacfuture and I were testing the payouts. I already completed this but the payouts aren't working right now.

Copy link

ubiquibot bot commented Jan 30, 2024

# No linked pull requests to close

@0x4007 0x4007 closed this as completed Jan 30, 2024
Copy link

ubiquibot bot commented Jan 30, 2024

+ Evaluating results. Please wait...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants