Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add system76 driver #290

Merged
merged 2 commits into from
Jan 18, 2025
Merged

feat: add system76 driver #290

merged 2 commits into from
Jan 18, 2025

Conversation

ssweeny
Copy link
Contributor

@ssweeny ssweeny commented Jan 12, 2025 •
edited
Loading

This PR adds drivers for certain System76 laptops, including hotkeys and custom fan control.

This should satisfy #192 at least as far as driver/kmod support.

@ssweeny ssweeny requested a review from castrojo as a code owner January 12, 2025 05:05
@ssweeny ssweeny force-pushed the add-system76-driver branch from 0fbb532 to 7fd9adb Compare January 15, 2025 03:51
bsherman
bsherman approved these changes Jan 18, 2025
View reviewed changes
Copy link
Contributor

@bsherman bsherman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me.

Only comment I have is about adding another 3rd party owned COPR repo... but that's being discussed in Discord, and ssweeny's COPR is already in our akmods repo since the previous system76 driver PR was merged 3 weeks ago.

@bsherman bsherman requested review from KyleGospo, m2Giles and a team January 18, 2025 17:39
@castrojo castrojo added this pull request to the merge queue Jan 18, 2025
Merged via the queue into ublue-os:main with commit adc4bb6 Jan 18, 2025
51 checks passed
@github-actions github-actions bot mentioned this pull request Jan 18, 2025
Open
@ssweeny
Copy link
Contributor Author

ssweeny commented Jan 18, 2025

This looks good to me.

Only comment I have is about adding another 3rd party owned COPR repo... but that's being discussed in Discord, and ssweeny's COPR is already in our akmods repo since the previous system76 driver PR was merged 3 weeks ago.

I'd be happy to "donate" the packages to the ublue COPR if that'd be better. 😄
I didn't notice in the docs if that was preferable or how to do it.

@ssweeny ssweeny deleted the add-system76-driver branch January 18, 2025 18:17
@bsherman
Copy link
Contributor

I'd be happy to "donate" the packages to the ublue COPR if that'd be better. 😄 I didn't notice in the docs if that was preferable or how to do it.

I don't think it's documented. :-) So thank you.

There's a thread discussing this in Discord, but my suggestion is this:

  1. transfer https://github.com/ssweeny/system76-driver-akmod to ublue-os org
  2. ensure @ssweeny still has write access to ublue-os/system76-driver-akmod since you are the defacto maintainer of these SPEC files :-)
  3. start building the RPMs in https://copr.fedorainfracloud.org/coprs/ublue-os/akmods/

@ssweeny
Copy link
Contributor Author

ssweeny commented Jan 18, 2025

Sounds good to me. I suppose this also applies to https://github.com/ssweeny/system76-io-akmod ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bsherman bsherman bsherman approved these changes

@castrojo castrojo castrojo approved these changes

@KyleGospo KyleGospo Awaiting requested review from KyleGospo

@m2Giles m2Giles Awaiting requested review from m2Giles

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ssweeny @bsherman @castrojo