Cleanly exit if cepces or getcert are not present #762
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Useful information like Samba logging is printed to stderr. We would like to have this information even in the successful runs of the script. It also adds value to print both stdout and stderr even in the failing case.
GabrielNagy
force-pushed
the
certificate-check-for-binaries
branch
from
5eead7f
to
ab81b95
Compare
Codecov Report
@@ Coverage Diff @@
## main #762 +/- ##
==========================================
+ Coverage 86.05% 86.07% +0.01%
==========================================
Files 77 77
Lines 8543 8552 +9
==========================================
+ Hits 7352 7361 +9
Misses 868 868
Partials 323 323
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
didrocks
approved these changes
Aug 9, 2023
We can leverage Samba's logging system to get a better understanding as to what's going on during the lifetime of the autoenroll script. Mock has to be wrangled a bit to satisfy the actual `lp` object.
In case certmonger or the cepces library are not installed we do not want to fail hard. Check for the existence of the binaries instead of debs to be more future-proof given that cepces is not yet packaged in Ubuntu. Fixes UDENG-1156
In case the binaries needed for certificate autoenrollment are not present on the system, avoid creating the needed directories. Also add a test to illustrate that we will not fail if the directory structure is wonky, if certmonger is not present.
GabrielNagy
force-pushed
the
certificate-check-for-binaries
branch
from
ab81b95
to
845ccfe
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In case
certmongeror thecepceslibrary are not installed we do not want to fail hard. Check for the existence of the binaries instead of debs to be more future-proof given that cepces is not yet packaged in Ubuntu.Fixes UDENG-1156
The PR contains some logging improvements as well, and a small optimization to avoid creating the needed directories if the required binaries are not present.