Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add documentation for certificate policy manager #772

Merged
merged 2 commits into from
Aug 24, 2023

Conversation

GabrielNagy
Copy link
Contributor

Fixes UDENG-1060

@codecov-commenter
Copy link

codecov-commenter commented Aug 23, 2023

Codecov Report

Merging #772 (51620fa) into main (a6a036a) will not change coverage.
Report is 2 commits behind head on main.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main     #772   +/-   ##
=======================================
  Coverage   86.07%   86.07%           
=======================================
  Files          77       77           
  Lines        8552     8552           
=======================================
  Hits         7361     7361           
  Misses        868      868           
  Partials      323      323           

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@GabrielNagy GabrielNagy marked this pull request as ready for review August 23, 2023 13:14
@GabrielNagy GabrielNagy requested a review from a team as a code owner August 23, 2023 13:14
Copy link
Member

@denisonbarbosa denisonbarbosa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Had a minor comment about the formatting, but everything else looks great.

doc/11.-Certificate-autoenrollment.md Outdated Show resolved Hide resolved
@GabrielNagy GabrielNagy force-pushed the certificate-enrollment-documentation branch from 6a6299a to 51620fa Compare August 23, 2023 15:27
@GabrielNagy GabrielNagy merged commit 5617c53 into main Aug 24, 2023
4 checks passed
@GabrielNagy GabrielNagy deleted the certificate-enrollment-documentation branch August 24, 2023 07:52
Copy link
Member

@didrocks didrocks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just 2 minor comments, but excellent documentation!

Request "galacticcafe-CA.Machine" removed.

# Remove CA
getcert remove-ca -c galacticcafe-CA
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

isn’t here a missing >?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Arghh yes 😅 very good eye - will update both these, thanks 🙇🏼

Then, run the script passing the required arguments (the argument list is also printed in the ADSys debug logs during policy application):
```sh-session
# Un-enroll machine
./cert-autoenroll unenroll keypress galacticcafe.com --state_dir /var/lib/adsys --debug
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ditto on missing > ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants