build: Fix pam_adsys build #789
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
And the proof: root@mantic-b4519d33:~# diff -u 0.13.0.txt 0.13.0ppa2.txt
--- 0.13.0.txt 2023-09-25 08:54:37.648222755 +0000
+++ 0.13.0ppa2.txt 2023-09-25 09:46:37.018948908 +0000
@@ -2,8 +2,8 @@
0
118 bytes, 2 lines conffiles
- 937 bytes, 17 lines control
- 5587 bytes, 72 lines md5sums
+ 959 bytes, 17 lines control
+ 5664 bytes, 73 lines md5sums
7075 bytes, 147 lines * postinst #!/bin/sh
872 bytes, 21 lines * postrm #!/bin/sh
811 bytes, 21 lines * prerm #!/bin/sh
@@ -11,7 +11,7 @@
13
Architecture: amd64
ubuntu
- Installed-Size: 27172
+ Installed-Size: 27236
34), libglib2
Recommends: ubuntu-advantage-desktop-daemon
Suggests: curlftpfs, ubuntu-proxy-manager, python3-cepces
@@ -43,6 +43,9 @@
/lib/systemd/system/adsysd
/lib/systemd/system/adsysd
/lib/systemd/system/run-adsys
+/lib/x86_64-linux-gnu/
+/lib/x86_64-linux-gnu/security/
+/lib/x86_64-linux-gnu/security/pam_adsys
/sbin/
/sbin/adsysd
/usr/PPA build at: https://launchpad.net/~gabuscus/+archive/ubuntu/ppa/+sourcepub/15173272/+listing-archive-extra |
didrocks
reviewed
Sep 25, 2023
Codecov Report
@@ Coverage Diff @@
## main #789 +/- ##
=======================================
Coverage 86.07% 86.07%
=======================================
Files 77 77
Lines 8552 8552
=======================================
Hits 7361 7361
Misses 868 868
Partials 323 323 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
didrocks
approved these changes
Sep 25, 2023
GabrielNagy
force-pushed
the
fix-pam-adsys-build
branch
from
f293785
to
8049a01
Compare
It looks like multiple -tags statements override each other so we must specify them in a comma separated way. This fixes the issue where pam_adsys is not built and shipped anymore.
GabrielNagy
force-pushed
the
fix-pam-adsys-build
branch
from
8049a01
to
b7d2c3c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It looks like multiple
-tagsstatements override each other so we must specify them in a comma separated way. This fixes the issue wherepam_adsysis not built and shipped anymore.