Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(completion): skip generated reference policies for completion #852

Merged
merged 2 commits into from
Nov 16, 2023

Conversation

didrocks
Copy link
Member

@didrocks didrocks commented Nov 16, 2023

This documentation will just pollute the completion with many items and is less worthwhile on the command line.


UDENG-1039

This documentation will just pollute the completion with many items and
is less worthwhile on the command line.
Exclude from the accounting asserts the skip parts.
@codecov-commenter
Copy link

Codecov Report

Attention: 2 lines in your changes are missing coverage. Please review.

Comparison is base (26199a4) 86.10% compared to head (ebde18d) 86.08%.

Files Patch % Lines
internal/adsysservice/doc.go 33.33% 1 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #852      +/-   ##
==========================================
- Coverage   86.10%   86.08%   -0.02%     
==========================================
  Files          76       76              
  Lines        8599     8602       +3     
==========================================
+ Hits         7404     7405       +1     
- Misses        866      867       +1     
- Partials      329      330       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@didrocks didrocks marked this pull request as ready for review November 16, 2023 07:00
@didrocks didrocks requested a review from a team as a code owner November 16, 2023 07:00
@didrocks didrocks requested a review from jibel November 16, 2023 07:01
Copy link
Collaborator

@jibel jibel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@didrocks didrocks merged commit 25acc4c into main Nov 16, 2023
6 checks passed
@didrocks didrocks deleted the completion-prepare-reference-doc branch November 16, 2023 08:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants