build: add nfs-common dependency #858
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The nfs-common package is required if NFS shares are to be mounted on the client. Unlike cifs-utils, this package is not installed by default on Ubuntu Desktop. Given that we declare the former as a dependency we should do the same with nfs-common. Fixes #809 / UDENG-1570
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #858 +/- ##
=======================================
Coverage 86.00% 86.00%
=======================================
Files 76 76
Lines 8718 8718
=======================================
Hits 7498 7498
Misses 883 883
Partials 337 337 ☔ View full report in Codecov by Sentry. |
didrocks
approved these changes
Nov 21, 2023
GabrielNagy
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
nfs-commonpackage is required if NFS shares are to be mounted on the client. Unlikecifs-utils, this package is not installed by default on Ubuntu Desktop. Given that we declare the former as a dependency we should do the same withnfs-common.Fixes #809 / UDENG-1570