feat(coverage): ship Corbertura assets as a zip for our partner #953
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
didrocks
changed the title
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #953 +/- ##
=======================================
Coverage 90.77% 90.77%
=======================================
Files 78 78
Lines 6886 6886
=======================================
Hits 6251 6251
Misses 621 621
Partials 14 14 ☔ View full report in Codecov by Sentry. |
They are requiring a zip file instead of the xml directly. Ship it both so that we still link the xml directly from README.
didrocks
force-pushed
the
cobertura_as_zip
branch
from
7f84c8b
to
37ef411
Compare
|
The failing e2e tests are due to the machines not being able to provision. It seems that our automatically updated machine are not available on any releases. It’s something to look with Gabriel and ensure we have docs over this. I think this is skippable for now as we don’t do a real release (and don’t have logical change compared to previous one). |
jibel
approved these changes
Mar 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
They are requiring a zip file instead of the xml directly. Ship both of it so that we still link the xml directly from README.
UDENG-2555