Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc(reference): Generate documentation for policies #848

Merged
merged 11 commits into from
Nov 16, 2023

Conversation

didrocks
Copy link
Member

Expand admxgen to generate documentation for policies.

This allows to create the necessary elements to dump all reference documentation in a given directory.
Those are formed from a template, when collecting supported referenced key.


UDENG-1039

We will generate then the documentation too, so split the names.
This is the internal recursive function to create documentation from a
md template, one each page, for each documentation policy.
Categories are sorted into folders, and both of them are split between
Computer and User policies.
Those tests are similar to the ones for expandedCategoriesToADMX
Those are similar to the ones from expandedCategoriesToADMX.
This collects any policies and then call our generation code.
High level tests, similar to GenerateAD tests, to collect and bootstrap
documentation generation.
Accompagning fixutres and golden files for generation policy
documentation code.
This new command generate policy documentation reference in destination
directory.
Those elements will expand to locate the registry key for the admin.
Do not use title for metadata/range/valid values. Otherwise, when
listing them in the toc, we will always end up with them listed at
the same level than the other elements (subdirectories/subsections).
This includes existing retitle and path refiltering.
@didrocks didrocks marked this pull request as ready for review November 15, 2023 14:45
@didrocks didrocks requested a review from a team as a code owner November 15, 2023 14:45
@didrocks didrocks requested a review from jibel November 15, 2023 14:45
Copy link
Collaborator

@jibel jibel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I checked that the generated files are correct.
Nothing burnt my eyes while reading the code.
Most of the PR is test code but I didn't check the coverage.
👍

@didrocks didrocks merged commit cabdeca into main Nov 16, 2023
16 checks passed
@didrocks didrocks deleted the documentation_for_policies branch November 16, 2023 09:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants