fix(tests): ensure early return when disabled

Author: Avantol13

cdispyutils/metrics.py

@@ -100,21 +100,6 @@ def increment_counter(self, name, labels, description=""):
         logger.debug(f"Incrementing counter '{name}' with labels: {labels}")
         self.prometheus_metrics[name].labels(*labels.values()).inc()
 
-    def _create_gauge_if_not_exist(self, name, labels, value, description):
-        if not self.enabled:
-            return
-
-        # create the gauge if it doesn't already exist
-        if name not in self.prometheus_metrics:
-            logger.info(
-                f"Creating gauge '{name}' with description '{description}' and labels: {labels}"
-            )
-            self.prometheus_metrics[name] = Gauge(name, description, [*labels.keys()])
-        elif type(self.prometheus_metrics[name]) is not Gauge:
-            raise ValueError(
-                f"Trying to create gauge '{name}' but a {type(self.prometheus_metrics[name])} with this name already exists"
-            )
-
     def dec_gauge(self, name, labels, value, description=""):
         """
         Decrement a Prometheus gauge metric.
@@ -126,6 +111,9 @@ def dec_gauge(self, name, labels, value, description=""):
             value (int): Value to set the metric to
             description (str): describing the gauge in case it doesn't already exist
         """
+        if not self.enabled:
+            return
+
         self._create_gauge_if_not_exist(name, labels, value, description)
         logger.debug(f"Decrementing gauge '{name}' by '{value}' with labels: {labels}")
         self.prometheus_metrics[name].labels(*labels.values()).dec(value)
@@ -141,6 +129,9 @@ def inc_gauge(self, name, labels, value, description=""):
             value (int): Value to set the metric to
             description (str): describing the gauge in case it doesn't already exist
         """
+        if not self.enabled:
+            return
+
         self._create_gauge_if_not_exist(name, labels, value, description)
         logger.debug(f"Incrementing gauge '{name}' by '{value}' with labels: {labels}")
         self.prometheus_metrics[name].labels(*labels.values()).inc(value)
@@ -155,6 +146,21 @@ def set_gauge(self, name, labels, value, description=""):
             labels (dict): Dictionary of labels for the metric
             value (int): Value to set the metric to
         """
+        if not self.enabled:
+            return
+
         self._create_gauge_if_not_exist(name, labels, value, description)
         logger.debug(f"Setting gauge '{name}' with '{value}' with labels: {labels}")
         self.prometheus_metrics[name].labels(*labels.values()).set(value)
+
+    def _create_gauge_if_not_exist(self, name, labels, value, description):
+        # create the gauge if it doesn't already exist
+        if name not in self.prometheus_metrics:
+            logger.info(
+                f"Creating gauge '{name}' with description '{description}' and labels: {labels}"
+            )
+            self.prometheus_metrics[name] = Gauge(name, description, [*labels.keys()])
+        elif type(self.prometheus_metrics[name]) is not Gauge:
+            raise ValueError(
+                f"Trying to create gauge '{name}' but a {type(self.prometheus_metrics[name])} with this name already exists"
+            )