Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cleanup_values analysis #548

Open
amywieliczka opened this issue Oct 10, 2023 · 1 comment
Open

cleanup_values analysis #548

amywieliczka opened this issue Oct 10, 2023 · 1 comment
Labels
enrichment analysis post-mvp enrichment analysis post-mvp

Comments

@amywieliczka
Copy link
Collaborator

Investigate everything that cleanup_values enrichment is doing, and whether or not this is desirable.

This enrichment was implemented incorrectly and during that time, we noticed some 'improvements' to the metadata getting reported out in our validation reports. See details here: #532

We wound up doing away with these 'improvements' to keep parity to the legacy system during the migration process.

This enrichment is complex, probably does too much, and it would be great to get rid of it. Especially if the metadata is actually "improved" as a result.
@amywieliczka amywieliczka added the enrichment analysis post-mvp enrichment analysis label Oct 25, 2023
@christinklez christinklez mentioned this issue Oct 25, 2023
Closed
@christinklez christinklez reopened this Oct 25, 2023
@amywieliczka
Copy link
Collaborator Author

Keep an eye out for trailing periods in rights and description fields, middle initials in creator and other fields containing names.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enrichment analysis post-mvp enrichment analysis post-mvp
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@amywieliczka @christinklez