New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add an output buffering for neuralmonkey-run #799

Open

varisd opened this issue Mar 1, 2019 · 2 comments

Labels

discussion enhancement

Member

varisd commented Mar 1, 2019

If I understand it correctly, when translating a dataset with neuralmonkey-run (using pretrained model), all the translations (or outputs) are held in the memory...
(this loop here: https://github.com/ufal/neuralmonkey/blob/master/neuralmonkey/learning_utils.py#L323)
... and only after producing all the outputs, they are being written into the output
(https://github.com/ufal/neuralmonkey/blob/master/neuralmonkey/learning_utils.py#L383)

When processing/translating large files, this might cause memory issues.

varisd added enhancement discussion support labels

jlibovicky removed the support label

Contributor

jlibovicky commented Mar 15, 2019

Totally agree.

Member

jindrahelcl commented Mar 15, 2019

+1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment