Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Forward decls in multi_handle.hxx #533

Open
mkrausex opened this issue Feb 21, 2023 · 3 comments
Open

Forward decls in multi_handle.hxx #533

mkrausex opened this issue Feb 21, 2023 · 3 comments

Comments

@mkrausex
Copy link
Contributor

There are two forward decls at the beginning of multi_handle.hxx which, according to a comment there, “Visual Studio doesn't like”, and are currently disabled via #ifndef _MSC_VER. However, Visual Studio 2019 in C++20 mode actually seems to expect these forward decls – the code compiles only if I enable them (i.e., when I remove the #ifndef _MSC_VER).

What would be a good solution? I guess that for some older version of Visual Studio, these forward decls had really been a problem originally. Maybe we should only keep them disabled for all Visual Studio versions before 2019, and enable them for 2019 and later? Or should it be conditional on the C++ standard version instead?

@hmaarrfk
Copy link
Collaborator

hmaarrfk commented Oct 1, 2023

I'm happy to be a little more agressive with the visual studio versions to help modernize the build.

Now that we have the CIs running, we can make a few CIs with different compiler versions.

@mkrausex
Copy link
Contributor Author

Do I understand you correctly that you are in favor of enabling these forward decls unconditionally - and accepting compilation problems on old Visual Studio versions? If yes, I can prepare a PR.

@hmaarrfk
Copy link
Collaborator

yes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants