Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Npm package precss causes build error. Is this plugin still needed? #222

Closed
hauff opened this issue Aug 18, 2022 · 1 comment
Closed

Npm package precss causes build error. Is this plugin still needed? #222

hauff opened this issue Aug 18, 2022 · 1 comment
Assignees
@hauff @Langenfeld @henkele @DaraKamalian
Labels
bug Something isn't working help wanted Extra attention is needed

Comments

@hauff
Copy link
Contributor

hauff commented Aug 18, 2022 •
edited
Loading

Npm package precss is disabled in dfedb42, because it causes the following build error ...

ERROR in ./scss/custom.scss (./node_modules/css-loader/dist/cjs.js!./node_modules/postcss-loader/dist/cjs.js??ruleSet[1].rules[1].use[2]!./node_modules/sass-loader/dist/cjs.js!./scss/custom.scss)
Module build failed (from ./node_modules/postcss-loader/dist/cjs.js):
TypeError: Cannot read properties of undefined (reading 'raws')

If we still need precss, this could be a workaround csstools/precss#139 (comment).
@hauff hauff added bug Something isn't working help wanted Extra attention is needed labels Aug 18, 2022
@hauff hauff changed the title Npm package precss causes build error. Is this plugin is still needed? Npm package precss causes build error. Is this plugin still needed? Aug 18, 2022
@DaraKamalian
Copy link

After removing precss from package.json and running npm build, I have tested hanfor and nothing seems to break!
So perhaps we don't need precss after all.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@hauff hauff

@Langenfeld Langenfeld

@henkele henkele

@DaraKamalian DaraKamalian

Labels
bug Something isn't working help wanted Extra attention is needed
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@hauff @Langenfeld @henkele @DaraKamalian