Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stop overwriting notifications timeout #313

Closed
freswa opened this issue Jul 31, 2024 · 1 comment · Fixed by #314
Closed

Stop overwriting notifications timeout #313

freswa opened this issue Jul 31, 2024 · 1 comment · Fixed by #314

Comments

@freswa
Copy link

freswa commented Jul 31, 2024

Here is a hardcoded timeout value set for all notifications. Usually there is a setting in the notification daemon, that handles the duration. Is there any particular reason this is hardcoded and not left to the notification daemon?

@ulyssa
Copy link
Owner

ulyssa commented Aug 1, 2024

Nope, there isn't a reason. I'm down to remove the timeout and let folk's desktop defaults apply. If it turns out that that lasts too long in some places, then I can add a timeout field to the settings to optionally set one. Thank you @pisquaredover6 for submitting #314! 🙏

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants