Skip to content

Commit 8b78a29

Browse files
committed
update DESCRIPTION to make cran happier. Update cran-comments
1 parent 9209f1c commit 8b78a29

File tree

2 files changed

+14
-15
lines changed

2 files changed

+14
-15
lines changed

DESCRIPTION

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -10,7 +10,7 @@ Description: Classical methods for combining summary data from genome-wide
1010
association studies (GWAS) only use marginal genetic effects and power can
1111
be compromised in the presence of heterogeneity. 'subgxe' is a R package
1212
that implements p-value assisted subset testing for association (pASTA),
13-
a method developed by Yu et al. (2019) \doi{10.1159/000496867}. pASTA
13+
a method developed by Yu et al. (2019) <doi:10.1159/000496867>. pASTA
1414
generalizes association analysis based on subsets by incorporating
1515
gene-environment interactions into the testing procedure.
1616
License: GPL-3

cran-comments.md

Lines changed: 13 additions & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -1,21 +1,13 @@
11
## Resubmission
22
This is a resubmission. CRAN comments were:
33

4-
> Thanks, please write package names, software names and API names in
5-
> single quotes (e.g. 'subgxe') in your Description.
6-
>
7-
> If there are references describing the methods in your package, please
8-
> add these in the Description field of your DESCRIPTION file in the form
4+
> Please write the reference in the form:
95
> authors (year) \<doi:...\>
10-
> authors (year) \<arXiv:...\>
11-
> authors (year, ISBN:...)
12-
> with no space after 'doi:', 'arXiv:' and angle brackets for auto-linking.
6+
> with no space after 'doi:' and angle brackets for auto-linking.
137
>
148
> Please fix and resubmit.
159
16-
I have single quoted the package name in the DESCRIPTION, and added a
17-
citation + DOI to the relevant methods paper.
18-
10+
Done.
1911

2012
## Test environments
2113
* Ubuntu 18.04.2 LTS : R 3.6.0, R-Devel 2019-06-12 r76696
@@ -24,7 +16,14 @@ citation + DOI to the relevant methods paper.
2416
There were no ERRORs or WARNINGs.
2517

2618
There was 1 NOTE:
27-
* checking CRAN incoming feasibility ... NOTE
28-
Maintainer: ‘Alexander Rix <alexrix@umich.edu>
19+
Maintainer: ‘Alexander Rix <alexrix@umich.edu>
20+
21+
New submission
22+
23+
Found the following (possibly) invalid DOIs:
24+
DOI: 10.1159/000496867
25+
From: DESCRIPTION
26+
Status: Forbidden
27+
Message: 403
2928

30-
New submission
29+
I'm not sure why the there is a 403 error, but the DOI is valid

0 commit comments

Comments
 (0)