Skip to content

API change from go-socket.io 1.4.3 to 1.4.4 #5

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
naxmefy opened this issue Oct 2, 2020 · 0 comments
Open

API change from go-socket.io 1.4.3 to 1.4.4 #5

naxmefy opened this issue Oct 2, 2020 · 0 comments

Comments

@naxmefy
Copy link

naxmefy commented Oct 2, 2020

// 1.4.3 -> go-socket.io uses import from go-engine.io
// 1.4.4 -> go-socket.io uses import from subpackage  go-socket.io/engineio

// breaks at Line 17 of server.go because esio refers Options from go-engine.io
// see Line 26 wrapper.go
// import on line 5 (from go-engine.io)

import(
    // ...
    engineio "github.com/googollee/go-engine.io"
    // ...
)

func NewServer(c *engineio.Options) (*Server, error)

import should be

import(
    // ...
    engineio "github.com/googollee/go-socket.io/engineio"
    // ...
)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant