From dc37288d71828ef7c16be40e49e07c70c8795a78 Mon Sep 17 00:00:00 2001 From: johnthagen Date: Thu, 25 May 2023 15:44:30 -0400 Subject: [PATCH 01/11] Add support for Django 4.2 --- .github/workflows/main.yml | 11 +++++++++++ setup.py | 1 + tox.ini | 2 +- 3 files changed, 13 insertions(+), 1 deletion(-) diff --git a/.github/workflows/main.yml b/.github/workflows/main.yml index bc9a569..960f805 100644 --- a/.github/workflows/main.yml +++ b/.github/workflows/main.yml @@ -45,6 +45,17 @@ jobs: toxenv: py311-django41 - python: "pypy-3.8" toxenv: pypy3-django41 + + - python: "3.8" + toxenv: py38-django42 + - python: "3.9" + toxenv: py39-django42 + - python: "3.10" + toxenv: py310-django42 + - python: "3.11" + toxenv: py311-django42 + - python: "pypy-3.8" + toxenv: pypy3-django42 steps: - uses: actions/checkout@v2 - name: Setup Python diff --git a/setup.py b/setup.py index cd318db..7409a1d 100644 --- a/setup.py +++ b/setup.py @@ -50,6 +50,7 @@ def find_version(*parts): 'Framework :: Django :: 3.2', 'Framework :: Django :: 4.0', 'Framework :: Django :: 4.1', + 'Framework :: Django :: 4.2', 'Intended Audience :: Developers', 'License :: OSI Approved :: MIT License', 'Operating System :: OS Independent', diff --git a/tox.ini b/tox.ini index efa353f..488a83e 100644 --- a/tox.ini +++ b/tox.ini @@ -2,7 +2,7 @@ envlist = py{36,37,38,39,310,py3}-django32 py{38,39,310,py3}-django40 - py{38,39,310,311,py3}-django{41,main} + py{38,39,310,311,py3}-django{41,42,main} [testenv] deps = djangomain: https://github.com/django/django/tarball/main From 24f442cd5497c4e05e1c7b234cd71acbaee8e9e2 Mon Sep 17 00:00:00 2001 From: johnthagen Date: Thu, 25 May 2023 15:53:16 -0400 Subject: [PATCH 02/11] Update Pypy testing to 3.9 --- .github/workflows/main.yml | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/.github/workflows/main.yml b/.github/workflows/main.yml index 960f805..1329694 100644 --- a/.github/workflows/main.yml +++ b/.github/workflows/main.yml @@ -23,7 +23,7 @@ jobs: toxenv: py39-django32 - python: "3.10" toxenv: py310-django32 - - python: "pypy-3.8" + - python: "pypy-3.9" toxenv: pypy3-django32 - python: "3.8" @@ -32,7 +32,7 @@ jobs: toxenv: py39-django40 - python: "3.10" toxenv: py310-django40 - - python: "pypy-3.8" + - python: "pypy-3.9" toxenv: pypy3-django40 - python: "3.8" @@ -43,7 +43,7 @@ jobs: toxenv: py310-django41 - python: "3.11" toxenv: py311-django41 - - python: "pypy-3.8" + - python: "pypy-3.9" toxenv: pypy3-django41 - python: "3.8" @@ -54,7 +54,7 @@ jobs: toxenv: py310-django42 - python: "3.11" toxenv: py311-django42 - - python: "pypy-3.8" + - python: "pypy-3.9" toxenv: pypy3-django42 steps: - uses: actions/checkout@v2 From 9e1b6ee6e87ba21445371e66e333a6cde1041fb6 Mon Sep 17 00:00:00 2001 From: Mario Rosa Date: Thu, 25 May 2023 17:12:10 -0400 Subject: [PATCH 03/11] try removing coverage check for pypy --- test/pytest_plugin/__init__.py | 3 +++ 1 file changed, 3 insertions(+) diff --git a/test/pytest_plugin/__init__.py b/test/pytest_plugin/__init__.py index cf7f78e..bb16761 100644 --- a/test/pytest_plugin/__init__.py +++ b/test/pytest_plugin/__init__.py @@ -1,4 +1,5 @@ import sys +import platform import pytest @@ -7,3 +8,5 @@ def pytest_load_initial_conftests(early_config, parser, args): if hasattr(sys, 'gettrace') and sys.gettrace() is not None and '--forked' in args: args.remove('--forked') + if platform.python_implementation() == 'PyPy': + args.remove('--cov-report=term-missing --cov=django_cleanup') From 107a1a7948568ec1dc2d373927989bd36cb2a324 Mon Sep 17 00:00:00 2001 From: Mario Rosa Date: Thu, 25 May 2023 17:22:27 -0400 Subject: [PATCH 04/11] add --no-cov --- test/pytest_plugin/__init__.py | 1 + 1 file changed, 1 insertion(+) diff --git a/test/pytest_plugin/__init__.py b/test/pytest_plugin/__init__.py index bb16761..32b3142 100644 --- a/test/pytest_plugin/__init__.py +++ b/test/pytest_plugin/__init__.py @@ -10,3 +10,4 @@ def pytest_load_initial_conftests(early_config, parser, args): args.remove('--forked') if platform.python_implementation() == 'PyPy': args.remove('--cov-report=term-missing --cov=django_cleanup') + args.add('--no-cov') From 2659eaa789dff32efd615751079bd20a4b035425 Mon Sep 17 00:00:00 2001 From: Mario Rosa Date: Thu, 25 May 2023 17:28:50 -0400 Subject: [PATCH 05/11] try separate removes --- test/pytest_plugin/__init__.py | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/test/pytest_plugin/__init__.py b/test/pytest_plugin/__init__.py index 32b3142..612e9e9 100644 --- a/test/pytest_plugin/__init__.py +++ b/test/pytest_plugin/__init__.py @@ -9,5 +9,6 @@ def pytest_load_initial_conftests(early_config, parser, args): if hasattr(sys, 'gettrace') and sys.gettrace() is not None and '--forked' in args: args.remove('--forked') if platform.python_implementation() == 'PyPy': - args.remove('--cov-report=term-missing --cov=django_cleanup') + args.remove('--cov-report=term-missing') + args.remove('--cov=django_cleanup') args.add('--no-cov') From 8be3e9d5266fec0b32d7b593970fcf07f69cdc98 Mon Sep 17 00:00:00 2001 From: Mario Rosa Date: Thu, 25 May 2023 17:30:14 -0400 Subject: [PATCH 06/11] backout changes --- test/pytest_plugin/__init__.py | 5 ----- 1 file changed, 5 deletions(-) diff --git a/test/pytest_plugin/__init__.py b/test/pytest_plugin/__init__.py index 612e9e9..cf7f78e 100644 --- a/test/pytest_plugin/__init__.py +++ b/test/pytest_plugin/__init__.py @@ -1,5 +1,4 @@ import sys -import platform import pytest @@ -8,7 +7,3 @@ def pytest_load_initial_conftests(early_config, parser, args): if hasattr(sys, 'gettrace') and sys.gettrace() is not None and '--forked' in args: args.remove('--forked') - if platform.python_implementation() == 'PyPy': - args.remove('--cov-report=term-missing') - args.remove('--cov=django_cleanup') - args.add('--no-cov') From 2a34c71c50a83849ab4b561a0942e539c4fc1945 Mon Sep 17 00:00:00 2001 From: Mario Rosa Date: Thu, 25 May 2023 17:31:49 -0400 Subject: [PATCH 07/11] pin asgiref --- test/requirements.txt | 1 + 1 file changed, 1 insertion(+) diff --git a/test/requirements.txt b/test/requirements.txt index a2dc4d4..f6026b1 100644 --- a/test/requirements.txt +++ b/test/requirements.txt @@ -7,3 +7,4 @@ pytest-pythonpath pytest-cov pytest-xdist pytest-forked +asgiref=3.6.0 From b174e78d363eba9ea2b797897c67eb7361d87742 Mon Sep 17 00:00:00 2001 From: Mario Rosa Date: Thu, 25 May 2023 17:32:26 -0400 Subject: [PATCH 08/11] typo --- test/requirements.txt | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/test/requirements.txt b/test/requirements.txt index f6026b1..37d6850 100644 --- a/test/requirements.txt +++ b/test/requirements.txt @@ -7,4 +7,4 @@ pytest-pythonpath pytest-cov pytest-xdist pytest-forked -asgiref=3.6.0 +asgiref==3.6.0 From 9e973e58b989082b36588b5534edb17bf7f06674 Mon Sep 17 00:00:00 2001 From: Mario Rosa Date: Thu, 25 May 2023 17:34:46 -0400 Subject: [PATCH 09/11] anything less than 3.7 --- test/requirements.txt | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/test/requirements.txt b/test/requirements.txt index 37d6850..7716de7 100644 --- a/test/requirements.txt +++ b/test/requirements.txt @@ -7,4 +7,4 @@ pytest-pythonpath pytest-cov pytest-xdist pytest-forked -asgiref==3.6.0 +asgiref<3.7.0 From 0f6003863b7c32f80ab3fa0ad574ee537492a9ed Mon Sep 17 00:00:00 2001 From: Mario Rosa Date: Tue, 13 Jun 2023 19:34:58 -0400 Subject: [PATCH 10/11] remove django40 --- .github/workflows/main.yml | 9 --------- CHANGELOG.md | 11 ++++++++++- README.rst | 6 +++--- setup.py | 1 - src/django_cleanup/__init__.py | 2 +- tox.ini | 3 --- 6 files changed, 14 insertions(+), 18 deletions(-) diff --git a/.github/workflows/main.yml b/.github/workflows/main.yml index 1329694..259f997 100644 --- a/.github/workflows/main.yml +++ b/.github/workflows/main.yml @@ -26,15 +26,6 @@ jobs: - python: "pypy-3.9" toxenv: pypy3-django32 - - python: "3.8" - toxenv: py38-django40 - - python: "3.9" - toxenv: py39-django40 - - python: "3.10" - toxenv: py310-django40 - - python: "pypy-3.9" - toxenv: pypy3-django40 - - python: "3.8" toxenv: py38-django41 - python: "3.9" diff --git a/CHANGELOG.md b/CHANGELOG.md index 59b6de9..03f7c6c 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -5,6 +5,13 @@ The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/), and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0.html). ## [Unreleased] +## [8.0.0] - 2023-06-xx +### Added +- Run tests for django 4.2. PR [#100] from [@johnthagen](https://github.com/johnthagen). + +### Removed +- Dropped support for django 4.0 + ## [7.0.0] - 2023-02-11 ### Added - Run tests for django 4.1. @@ -82,7 +89,8 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0 ## [0.1.4] - 2012-08-16 ## [0.1.0] - 2012-08-14 -[Unreleased]: https://github.com/un1t/django-cleanup/compare/7.0.0...HEAD +[Unreleased]: https://github.com/un1t/django-cleanup/compare/8.0.0...HEAD +[8.0.0]: https://github.com/un1t/django-cleanup/compare/7.0.0...8.0.0 [7.0.0]: https://github.com/un1t/django-cleanup/compare/6.0.0...7.0.0 [6.0.0]: https://github.com/un1t/django-cleanup/compare/5.2.0...6.0.0 [5.2.0]: https://github.com/un1t/django-cleanup/compare/5.1.0...5.2.0 @@ -118,6 +126,7 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0 [0.1.4]: https://github.com/un1t/django-cleanup/compare/0.1.0...0.1.4 [0.1.0]: https://github.com/un1t/django-cleanup/releases/tag/0.1.0 +[#100]: https://github.com/un1t/django-cleanup/pull/100 [#98]: https://github.com/un1t/django-cleanup/issues/98 [#96]: https://github.com/un1t/django-cleanup/issues/96 [#89]: https://github.com/un1t/django-cleanup/issues/89 diff --git a/README.rst b/README.rst index 6fea595..83409a3 100644 --- a/README.rst +++ b/README.rst @@ -11,7 +11,7 @@ is set as the :code:`FileField`'s default value will not be deleted. Compatibility ------------- -- Django 3.2, 4.0, 4.1 (`See Django Supported Versions `_) +- Django 3.2, 4.1, 4.2 (`See Django Supported Versions `_) - Python 3.6+ - Compatible with `sorl-thumbnail `_ - Compatible with `easy-thumbnail `_ @@ -164,9 +164,9 @@ Install, setup and use pyenv_ to install all the required versions of cPython (see the `tox.ini `_). Setup pyenv_ to have all versions of python activated within your local django-cleanup repository. -Ensuring that the python 3.10 that was installed is first priority. +Ensuring that the python 3.11 that was installed is first priority. -Install tox_ on python 3.10 and run the :code:`tox` command from your local django-cleanup +Install tox_ on python 3.11 and run the :code:`tox` command from your local django-cleanup repository. How to write tests diff --git a/setup.py b/setup.py index 7409a1d..b2d2d58 100644 --- a/setup.py +++ b/setup.py @@ -48,7 +48,6 @@ def find_version(*parts): 'Environment :: Web Environment', 'Framework :: Django', 'Framework :: Django :: 3.2', - 'Framework :: Django :: 4.0', 'Framework :: Django :: 4.1', 'Framework :: Django :: 4.2', 'Intended Audience :: Developers', diff --git a/src/django_cleanup/__init__.py b/src/django_cleanup/__init__.py index 89b31a9..cfc4286 100644 --- a/src/django_cleanup/__init__.py +++ b/src/django_cleanup/__init__.py @@ -4,4 +4,4 @@ will delete files on model instance deletion. ''' -__version__ = '7.0.0' +__version__ = '8.0.0' diff --git a/tox.ini b/tox.ini index 488a83e..0e937f7 100644 --- a/tox.ini +++ b/tox.ini @@ -1,7 +1,6 @@ [tox] envlist = py{36,37,38,39,310,py3}-django32 - py{38,39,310,py3}-django40 py{38,39,310,311,py3}-django{41,42,main} [testenv] deps = @@ -10,8 +9,6 @@ deps = django42: django<4.3 # August 2022 - December 2023 django41: django<4.2 - # December 2021 - April 2023 - django40: django<4.1 # LTS April 2021 - April 2024 django32: django<3.3 -rtest/requirements.txt From 40078dafcd53ed8254810a1a7e1d204270d05d35 Mon Sep 17 00:00:00 2001 From: Mario Rosa Date: Wed, 14 Jun 2023 17:58:51 -0400 Subject: [PATCH 11/11] changelog date --- CHANGELOG.md | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/CHANGELOG.md b/CHANGELOG.md index 03f7c6c..1be583a 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -5,12 +5,12 @@ The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/), and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0.html). ## [Unreleased] -## [8.0.0] - 2023-06-xx +## [8.0.0] - 2023-06-14 ### Added - Run tests for django 4.2. PR [#100] from [@johnthagen](https://github.com/johnthagen). ### Removed -- Dropped support for django 4.0 +- Dropped support for django 4.0. ## [7.0.0] - 2023-02-11 ### Added