Skip to content
This repository has been archived by the owner on Apr 25, 2024. It is now read-only.

Bug: Images are missing for ledger wallet instructions when signing a transaction #112

Open
1 of 5 tasks
waldenraines opened this issue May 20, 2020 · 1 comment
Open
1 of 5 tasks
Labels
bug Something isn't working

Comments

@waldenraines
Copy link
Contributor

I'm submitting a…

  • Regression (a behavior that used to work and stopped working in a new release)
  • Bug report
  • Feature request
  • Documentation issue or request
  • Support request

Expected Behavior

Ledger wallet instructions should be displayed.

Current Behavior

See screenshot. The images for the ledger steps are missing when you attempt to sign a transaction:

82fd277c-777a-4fd4-ad66-32c40431bdfb

Possible Solution

This could actually be a problem in unchained-wallets.

Steps to Reproduce (for bugs)

  1. Create a wallet that includes a ledger as one of the xpubs
  2. Create a spend transaction
  3. Attempt to sign with the ledger
  4. Note that images are missing

Environment

  • Where are you running caravan: localhost
  • Operating system: Linux
  • Browser and version: Chrome
caravan@0.2.0 /home/walden/code/caravan
├── unchained-bitcoin@0.0.13 
└─┬ unchained-wallets@0.0.12 
  └── unchained-bitcoin@0.0.12 

npm: 6.14.4 
node: v12.16.2
Linux 5.6.13-arch1-1 #1 SMP PREEMPT Thu, 14 May 2020 06:52:53 +0000 x86_64 GNU/Linux
@bucko13
Copy link
Contributor

bucko13 commented May 21, 2020

I think this might be a bug with unchained-bitcoin not having these images yet rather than caravan but I'd have to double check.

@bucko13 bucko13 added the invalid This doesn't seem right label May 21, 2020
@bucko13 bucko13 added bug Something isn't working and removed invalid This doesn't seem right labels May 28, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants