Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing other Unit Pattern for sd Locale in the Data for Long Currency #5374

Open
younies opened this issue Aug 15, 2024 · 5 comments
Open
Assignees
Labels
C-numbers Component: Numbers, units, currencies

Comments

@younies
Copy link
Member

younies commented Aug 15, 2024

According to Unicode Technical Standard #35, the other unit pattern must be present in the data.

However, in this PR: #5351, the data was missing for the sd locale. See this commit: e85e959.

What shall we do in this case?

@younies younies self-assigned this Aug 15, 2024
@younies younies added C-numbers Component: Numbers, units, currencies discuss-priority Discuss at the next ICU4X meeting labels Aug 15, 2024
@younies
Copy link
Member Author

younies commented Aug 15, 2024

and Other is always exist, it is better to have an external type other_patter/default_pattern : Cow<'data, str> , so, in the code we do not need to trust unwrap

@robertbastian
Copy link
Member

Can you locate this missing value in CLDR-JSON?

@sffc
Copy link
Member

sffc commented Aug 15, 2024

@robertbastian
Copy link
Member

That^ PR is not related to this. It does not remove the sd locale, because there is data for it.

@sffc
Copy link
Member

sffc commented Aug 20, 2024

UTS 35 says:

The numberSystem attribute is used to specify that the given number formatting pattern(s) are to be used when the given numbering system is active. By default, number formatting patterns without a specific numberSystem attribute are assumed to be used for the "latn" numbering system, which is western (ASCII) digits. Locales that specify a numbering system other than "latn" as the default should also specify number formatting patterns that are appropriate for use within the context of the given numbering system. For more information on numbering systems and their definitions, see Section 1: Numbering Systems.

We confirmed that in the sd locale, there is a pattern in latn but not arab, but the default numbering system is arab.

There should be a CLDR issue filed about this.

@sffc sffc removed the discuss-priority Discuss at the next ICU4X meeting label Aug 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C-numbers Component: Numbers, units, currencies
Projects
None yet
Development

No branches or pull requests

3 participants