Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make VarZeroVec branchless like ZeroVec #5507

Open
sffc opened this issue Sep 5, 2024 · 0 comments
Open

Make VarZeroVec branchless like ZeroVec #5507

sffc opened this issue Sep 5, 2024 · 0 comments
Assignees
@Manishearth
Labels
2.0-breaking Changes that are breaking API changes C-zerovec Component: Yoke, ZeroVec, DataBake
Milestone
ICU4X 2.0 ⟨P1⟩

Comments

@sffc
Copy link
Member

sffc commented Sep 5, 2024

As discussed in #5434 (comment)

To start, we should make VarZeroVec have private fields in 2.0. The actual optimization can be done later.
@sffc sffc added 2.0-breaking Changes that are breaking API changes C-zerovec Component: Yoke, ZeroVec, DataBake labels Sep 5, 2024
@sffc sffc added this to the ICU4X 2.0 ⟨P1⟩ milestone Sep 5, 2024
@sffc sffc mentioned this issue Sep 5, 2024
Merged
@Manishearth Manishearth mentioned this issue Sep 9, 2024
Open
15 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Manishearth Manishearth

Labels
2.0-breaking Changes that are breaking API changes C-zerovec Component: Yoke, ZeroVec, DataBake
Projects
icu4x 2.0
Status: Small breakage (defer to end)
Milestone
ICU4X 2.0 ⟨P1⟩
Development

No branches or pull requests
2 participants
@sffc @Manishearth