Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename TimeZoneFormatsV1 to TimeZoneEssentialsV1 and migrate to icu_pattern #5545

Open
sffc opened this issue Sep 16, 2024 · 1 comment
Open

Rename TimeZoneFormatsV1 to TimeZoneEssentialsV1 and migrate to icu_pattern #5545

sffc opened this issue Sep 16, 2024 · 1 comment
Labels
C-time-zone Component: Time Zones S-small Size: One afternoon (small bug fix or enhancement)
Milestone
ICU4X 2.0 Stretch...

Comments

@sffc
Copy link
Member

sffc commented Sep 16, 2024

TimeZoneFormatsV1 has unused fields and it uses runtime string replacement instead of icu_pattern. This should be fixed. Shouldn't take long and it will be a pain to do it post-2.0.
@sffc sffc added S-small Size: One afternoon (small bug fix or enhancement) C-time-zone Component: Time Zones labels Sep 16, 2024
@sffc sffc added this to the ICU4X 2.0 ⟨P1⟩ milestone Sep 16, 2024
@sffc
Copy link
Member Author

sffc commented Sep 17, 2024

Also look into potentially-unused fields and whether we need them. #4920

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
C-time-zone Component: Time Zones S-small Size: One afternoon (small bug fix or enhancement)
Projects
icu4x 2.0
Status: Unclaimed for sprint
Milestone
ICU4X 2.0 Stretch ⟨P2⟩
Development

No branches or pull requests
1 participant
@sffc