Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The no_std feature has no effect #30

Open
Liamolucko opened this issue May 12, 2022 · 1 comment
Open

The no_std feature has no effect #30

Liamolucko opened this issue May 12, 2022 · 1 comment

Comments

@Liamolucko
Copy link

The no_std feature has no effect, because #![no_std] is unconditionally enabled (as it should be, since this crate has no reliance on std). It seems like this became the case in 02cc96c.

It should be removed or deprecated (probably deprecated, to avoid the breaking change), and the docs should reflect that #![no_std] is always enabled.

@Manishearth
Copy link
Member

I think we had it in there for backcompat, but we can mark it as deprecated

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants