Add uksignal compatibility #4
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4 signal related functions are now provided trough uksignal. Remove the stubs from glue.c to avoid linking errors. Signed-off-by: Răzvan Vîrtan <virtanrazvan@gmail.com>
razvand
requested changes
Nov 6, 2021
razvand
added
bug
At this moment uksignal doesn't support real time signals (signal codes greater than 31). However, the Go runtime assumes that it does and it tries to init signals up to SIGRTMAX, causing any go application to fail. This commit avoids this situation. These changes should be removed when real time signals support will be added to uksignal. Signed-off-by: Răzvan Vîrtan <virtanrazvan@gmail.com>
razvanvirtan
force-pushed
the
uksignal_compatible
branch
from
17683fc to
432f22b
Compare
razvand
approved these changes
Nov 13, 2021
There was a problem hiding this comment.
All is OK.
Reviewed-by: Razvan Deaconescu razvan.deaconescu@cs.pub.ro
|
Approved-by: Razvan Deaconescu razvan.deaconescu@cs.pub.ro |
unikraft-bot
pushed a commit
that referenced
this pull request
Nov 27, 2021
4 signal related functions are now provided trough uksignal. Remove the stubs from glue.c to avoid linking errors. Signed-off-by: Răzvan Vîrtan <virtanrazvan@gmail.com> Reviewed-by: Razvan Deaconescu <razvan.deaconescu@cs.pub.ro> Approved-by: Razvan Deaconescu <razvan.deaconescu@cs.pub.ro> Tested-by: Unikraft CI <monkey@unikraft.io> GitHub-Pull-Request: #4
unikraft-bot
pushed a commit
that referenced
this pull request
Nov 27, 2021
At this moment uksignal doesn't support real time signals (signal codes greater than 31). However, the Go runtime assumes that it does and it tries to init signals up to SIGRTMAX, causing any go application to fail. This commit avoids this situation. These changes should be removed when real time signals support will be added to uksignal. Signed-off-by: Răzvan Vîrtan <virtanrazvan@gmail.com> Reviewed-by: Razvan Deaconescu <razvan.deaconescu@cs.pub.ro> Approved-by: Razvan Deaconescu <razvan.deaconescu@cs.pub.ro> Tested-by: Unikraft CI <monkey@unikraft.io> GitHub-Pull-Request: #4
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After the uksignal support was integrated to newlib, some changes are required to libgo too.
The changes related to the total signals number need to be reverted when uksignal will provide real-time signals support.
Signed-off-by: Răzvan Vîrtan virtanrazvan@gmail.com